Trim "Async" Suffix #39128
Closed
Trim "Async" Suffix #39128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-mvc
mkArtakMSFT
added
old-area-web-frameworks-do-not-use
rafikiassumani-msft
added
pr: pending author input
pranavkm
reviewed
Jan 21, 2022
| private static string TrimAsyncSuffix(string actionName) | ||
| { | ||
| const string suffix = "Async"; | ||
| if (actionName.EndsWith(suffix, false, CultureInfo.InvariantCulture)) |
There was a problem hiding this comment.
Doing this unconditionally wouldn't be right (if say the option to trim the Async suffix is disabled). Could you describe a possible solution in the issue before we start writing code? Thanks!
|
Closing this until we can discuss the right way to go about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8998
Current state of implementation