[release/3.1] Update SPA template JS dependencies

[MackinnonBuck]

Update SPA template JS dependencies

Includes the routine update for SPA template dependencies. In addition, .js files importing react-router now instead import react-router-dom to accommodate a breaking change in a previous JS package update.

Description

This PR makes two changes:

• Updates the JS dependency tree for the React, React+Redux, and Angular SPA templates.
• Applies a fix for a bug introduced in a breaking change to a previous JS package update. The React templates had been mixing the use of react-router and react-router-dom, which only manifested itself as a real problem in the 3.1.25 SPA templates. The fix is to change all .js files importing react-router to instead import react-router-dom.

Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/1380

Customer Impact

Without the code change, customers will have to manually make the change themselves for all new SPA projects created from the templates in .NET Core 3.1. Without this fix, the error message that gets logged does not make the required code change obvious to customers.

Regression?

• Yes
• No

Regressed from .NET Core 3.1.24

Risk

• High
• Medium
• Low

The fix simply adjusts our code to reference the correct package (react-router-dom instead of react-router). Other changes are the routine JS dependency updates.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

[ghost]

Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[wtgodbe]

Should the corresponding package.json files get updated too?

[MackinnonBuck]

The package.json files didn't change, I just regenerated package-lock.json to update the dependency tree.

[MackinnonBuck]

Let's wait to merge this - I still need to complete some validations.

[wtgodbe]

@MackinnonBuck let me know when you want this merged (branches are open until EOD Monday)

[dougbu]

Why is this a tell-mode change when it changes project template content❔ I'm probably missing something…

[MackinnonBuck]

@dougbu Last month's dependency updates introduced a bug that is fixed by importing react-router-dom instead of react-router. Do you think this change is significant enough to bring this PR out of tell mode?

[dougbu]

Do you think this change is significant enough to bring this PR out of tell mode?

I defer to @Pilchie

[Pilchie]

Let's split the difference - instead of just applying the label, let's actually send a mail to tactics with info about the change so that it's more broadly known, but not block on approval.

[MackinnonBuck]

@wtgodbe I've completed my validations and the mail has been sent to tactics - can this be approved/merged now?

[dougbu]

Since @javiercn is likely done for the day, I could approve but it would be better for someone at least slightly familiar w/ these two packages. Let me know if there's no one else around today

[dougbu]

Thanks @javiercn❕