Updated VS workload manifests to Windows SDK 19041 #42457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
BrennanConroy
approved these changes
Jun 27, 2022
dougbu
approved these changes
Jun 27, 2022
|
Oops, "please update" |
dougbu
reviewed
Jun 27, 2022
| <!-- General properties --> | ||
|
|
||
| <PropertyGroup> | ||
| <!-- If the following line is updated ensure that the /eng/scripts/vs.17.*.json files are updated to include the same version component too. --> |
There was a problem hiding this comment.
This, this addresses half of my internal comment
Similar lines exist in src\Installers\Windows\AspNetCoreModule-Setup\build\settings\common.props and src\Servers\IIS\AspNetCoreModuleV2\CommonLibTests\CommonLibTests.vcxproj. I think the second one is redundant but, if that one stays, they both should probably have the same comment.
|
|
||
| <PropertyGroup> | ||
| <!-- If the following line is updated ensure that the /eng/scripts/vs.17.*.json files are updated to include the same version component too. --> | ||
| <IisOobWinSdkVersion Condition="'$(IisOobWinSdkVersion)' == ''">10.0.18362.0</IisOobWinSdkVersion> |
There was a problem hiding this comment.
anyone know if this line is now incorrect❔
DamianEdwards
requested review from
JamesNK,
Tratcher and
halter73
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the vs workload manifests to match latest windows sdk version being used.