Bump Microsoft.AspNetCore.Server.IIS from 2.2.0 to 2.2.6 in /src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite #42624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [Microsoft.AspNetCore.Server.IIS](https://github.com/aspnet/AspNetCore) from 2.2.0 to 2.2.6. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](2.2.0...v2.2.6) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Server.IIS dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
Tratcher,
halter73,
BrennanConroy and
JamesNK
as code owners
dependabot
bot
added
.NET
feature-blazor-native-dependencies
ghost
added
the
dougbu
reviewed
Jul 8, 2022
src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite/InProcessNewShimWebSite.csproj
Show resolved
Hide resolved
dougbu
approved these changes
Jul 11, 2022
dougbu
changed the title
|
Approved and enabled auto-squish |
|
Ugh, the InProcessNewShimWebSite project only references 2.2-era packages and no new product code (aside from the installed ANCM shim). Should I change the test to use the current shared framework instead❔ Or, should the test asset and tests that use it be removed❔ |
dougbu
force-pushed
the
dependabot/nuget/src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite/Microsoft.AspNetCore.Server.IIS-2.2.6
branch
from
619a7d9 to
ab518bb
Compare
dougbu
changed the title
|
Simplest change was the original one. But we can still remove the test asset if anyone feels that's better. Reverted the PR title too. |
|
@Tratcher please approve if you agree on this approach |
dougbu
deleted the
dependabot/nuget/src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite/Microsoft.AspNetCore.Server.IIS-2.2.6
branch
|
@Tratcher exactly what tests are no longer needed, the new shim/old shim tests? |
|
The tests that rely on the 2.2 packages, unless we can refactor them to target 3.1. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Microsoft.AspNetCore.Server.IIS from 2.2.0 to 2.2.6.
Release notes
Sourced from Microsoft.AspNetCore.Server.IIS's releases.
Commits
e7f262eMerge in 'release/2.2' changes2c9e5c9Merge branch 'release/2.1' => 'release/2.2' #11236d2327a5Merge branch 'release/2.1' into release/2.219dc9d1Merge in 'release/2.2' changesd858156Fix order in which EF properties are set21f6b5fUpdate submodules.props for EF 2.2.6f74ca43Always include ANCM in build output (#11199)2b771cdMerge in 'release/2.2' changes0460bc3Always include ANCM in build output (#11198)39c7419Merge in 'release/2.2' changesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.