Add header dictionary analyzer and fixer #44123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
a team,
dougbu,
wtgodbe and
Pilchie
as code owners
ghost
added
the
area-infrastructure
JamesNK
requested review from
DamianEdwards,
MackinnonBuck,
BrennanConroy,
halter73 and
captainsafia
src/Framework/AspNetCoreAnalyzers/src/Analyzers/DiagnosticDescriptors.cs
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Http/HeaderDictionaryIndexerAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/test/Verifiers/CSharpAnalyzerVerifier.cs
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/test/Microsoft.AspNetCore.App.Analyzers.Test.csproj
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Http/HeaderDictionaryIndexerAnalyzer.cs
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Http/HeaderDictionaryIndexerAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/test/Http/HeaderDictionaryIndexerAnalyzerTests.cs
Show resolved
Hide resolved
|
Brought in changes from #44061 so I can get all tests to pass when I update the verifiers. It's merged in release/7.0, and will get merged to main soon. Small merge conflict to resolve depending on who gets merged first 💪 |
JamesNK
force-pushed
the
jamesnk/headerdictionary-analyzer
branch
from
9ae0e7c to
8b59ba0
Compare
captainsafia
approved these changes
Sep 26, 2022
JamesNK
force-pushed
the
jamesnk/headerdictionary-analyzer
branch
from
ad5aaf4 to
76cd4d5
Compare
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44116