[release/7.0] gRPC JSON transcoding: Support deserializing non-nested enum from string #45411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
JamesNK and
captainsafia
as code owners
ghost
added
the
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Successfully manual verification in a test app. Enum string in JSON is successfully deserialized:
|
BrennanConroy
approved these changes
Dec 2, 2022
JamesNK
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
Approved over email. @dotnet/aspnet-build Could you please merge this PR into release/7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45273 to release/7.0
/cc @JamesNK
gRPC JSON transcoding: Support deserializing non-nested enum from string
gRPC JSON transcoding allows gRPC endpoints to be called as RESTful APIs with JSON.
Description
There is a bug in the serializer that means root scope enum values can't be deserialized from strings. This PR adds a type registry that stores the enum types and can be checked by the serializer.
Fixes #45270
Customer Impact
The bug prevents customers from having incoming messages with root scope enum values. An error is thrown.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This change only impacts gRPC JSON transcoding. The change has been added so that only the deserialization of a root scope enum uses the new registry in .NET 7.
Verification
Packaging changes reviewed?