Skip to content

RDG array handling. #47086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 16, 2023
Merged

RDG array handling. #47086

merged 12 commits into from
Mar 16, 2023

Conversation

mitchdenny
Copy link
Member

Addresses #46785

@ghost ghost added the area-runtime label Mar 8, 2023
@mitchdenny mitchdenny force-pushed the rdg-array-handling branch from 1b8a000 to 39189b0 Compare March 8, 2023 23:09
captainsafia
captainsafia reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RequestDelegateFactory processes arrays of things only if DisableInferBodyFromParameters is true. This property is typically set if the request is a non-POST request (see this code). We might want to consider respecting this property here to avoid inadvertently triggering this code path for MapPost types.

@mitchdenny
Copy link
Member Author

The RequestDelegateFactory processes arrays of things only if DisableInferBodyFromParameters is true. This property is typically set if the request is a non-POST request (see this code). We might want to consider respecting this property here to avoid inadvertently triggering this code path for MapPost types.

I don't look at processing arrays from request body at all in this PR. I'm only sourcing from either query string or headers. I can see that we need to handle the from body scenario though. I might follow this up with another PR unless you think what I've got here is unsafe even in the query string/headers scenario.

@mitchdenny
Copy link
Member Author

Ah sorry, I think I misunderstood what you are talking about. Looking more closely at the MapPost behavior I can see what you mean.

@mitchdenny mitchdenny requested a review from captainsafia March 13, 2023 06:28
@mitchdenny
Copy link
Member Author

@captainsafia reacted to changes on main, but also added logic to decide when to infer parameters from body.

captainsafia
captainsafia reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! We should consolidate the tests that are in RDFTests with these to make sure that we haven't missed any bugs...

@mitchdenny
Copy link
Member Author

Looks good overall! We should consolidate the tests that are in RDFTests with these to make sure that we haven't missed any bugs...

Good call. I've found a few bugs in doing this around arrays of nullables.

@mitchdenny mitchdenny requested a review from captainsafia March 15, 2023 09:24
captainsafia
captainsafia reviewed Mar 15, 2023
View reviewed changes
mitchdenny and others added 2 commits March 16, 2023 09:46
@mitchdenny mitchdenny requested a review from captainsafia March 16, 2023 02:10
captainsafia
captainsafia approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Follow ups include handling DisableInferBodyFromParameters as a runtime value and removing duplicate RDF tests.

@build-analysis build-analysis bot mentioned this pull request Mar 16, 2023
Open
5 tasks
@mitchdenny mitchdenny merged commit 354efd4 into dotnet:main Mar 16, 2023
@ghost ghost added this to the 8.0-preview3 milestone Mar 16, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchdenny @davidfowl @captainsafia @amcasey