-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Remove Spa-templates from repo #49413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -35,15 +35,6 @@ internal static class TemplatePackageInstaller | |||
"Microsoft.DotNet.Web.ProjectTemplates.6.0", | |||
"Microsoft.DotNet.Web.ProjectTemplates.7.0", | |||
"Microsoft.DotNet.Web.ProjectTemplates.8.0", | |||
"Microsoft.DotNet.Web.Spa.ProjectTemplates.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DamianEdwards do we want to leave around everything except 8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danroth27 your call. I would think we would remove all of these so that the 8.0 SDK doesn't carry any SPA project templates at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove them all.
Thanks @wtgodbe! |
Do you know where are the new templates after removing the old ones? |
Hi @zcxsythenew. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Hi @zcxsythenew. The new ASP.NET Core SPA templates now ship as part of Visual Studio. You can try them out with the latest Visual Studio preview release. |
Hi @danroth27. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@danroth27 Yes, I know it, but there is something wrong with these templates, and I want to raise an issue or PR. Are they not available on GitHub? (See #51341 for details) |
Hi @zcxsythenew. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Resolves #49388