Skip to content

Remove Spa-templates from repo #49413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Remove Spa-templates from repo #49413

merged 5 commits into from
Jul 14, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 14, 2023

Resolves #49388

@wtgodbe wtgodbe requested review from a team, captainsafia and mkArtakMSFT as code owners July 14, 2023 16:49
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Jul 14, 2023
@@ -35,15 +35,6 @@ internal static class TemplatePackageInstaller
"Microsoft.DotNet.Web.ProjectTemplates.6.0",
"Microsoft.DotNet.Web.ProjectTemplates.7.0",
"Microsoft.DotNet.Web.ProjectTemplates.8.0",
"Microsoft.DotNet.Web.Spa.ProjectTemplates.2.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamianEdwards do we want to leave around everything except 8.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danroth27 your call. I would think we would remove all of these so that the 8.0 SDK doesn't carry any SPA project templates at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove them all.

@mkArtakMSFT
Copy link
Contributor

Thanks @wtgodbe!
@MackinnonBuck can you please review this?

@wtgodbe wtgodbe merged commit 2403770 into main Jul 14, 2023
@wtgodbe wtgodbe deleted the wtgodbe/SpaTempl branch July 14, 2023 23:14
@ghost ghost added this to the 8.0-preview7 milestone Jul 14, 2023
@zcxsythenew
Copy link
Contributor

Do you know where are the new templates after removing the old ones?

@ghost
Copy link

ghost commented Oct 13, 2023

Hi @zcxsythenew. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@danroth27
Copy link
Member

Do you know where are the new templates after removing the old ones?

Hi @zcxsythenew. The new ASP.NET Core SPA templates now ship as part of Visual Studio. You can try them out with the latest Visual Studio preview release.

@ghost
Copy link

ghost commented Oct 13, 2023

Hi @danroth27. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@zcxsythenew
Copy link
Contributor

Do you know where are the new templates after removing the old ones?

Hi @zcxsythenew. The new ASP.NET Core SPA templates now ship as part of Visual Studio. You can try them out with the latest Visual Studio preview release.

@danroth27 Yes, I know it, but there is something wrong with these templates, and I want to raise an issue or PR. Are they not available on GitHub? (See #51341 for details)

@ghost
Copy link

ghost commented Oct 15, 2023

Hi @zcxsythenew. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the ASP.NET Core Angular & React templates from the .NET SDK for .NET 8
5 participants