Skip to content

[OutputCaching] OutputCacheOptions.ApplicationServices is always null during initialization #55847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

[OutputCaching] OutputCacheOptions.ApplicationServices is always null during initialization #55847

merged 3 commits into from
Oct 7, 2024

Conversation

feiyun0112
Copy link
Contributor

fix #55805

@feiyun0112 feiyun0112 requested a review from BrennanConroy as a code owner May 23, 2024 02:05
@ghost ghost added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label May 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Aug 8, 2024
@mkArtakMSFT mkArtakMSFT removed the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 9, 2024
mkArtakMSFT added a commit that referenced this pull request Sep 10, 2024
@mkArtakMSFT
Remove area- assignment rule as we now rely on dotnet-issue-labeler t…
698e6b6 
…o handle this

Without this change many PRs were getting labeled with duplicate labels and this automation was very invasive, as the labelers were getting added even after removing some labels manually. Here is an example PR where I've noticed this: #55847
@mkArtakMSFT mkArtakMSFT mentioned this pull request Sep 10, 2024
Merged
mkArtakMSFT added a commit that referenced this pull request Sep 10, 2024
@mkArtakMSFT
Remove area- assignment rule as we now rely on dotnet-issue-labeler t…
f2ea31d 
…o handle this (#57775)

Without this change many PRs were getting labeled with duplicate labels and this automation was very invasive, as the labelers were getting added even after removing some labels manually. Here is an example PR where I've noticed this: #55847
@mkArtakMSFT mkArtakMSFT removed the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 10, 2024
@BrennanConroy BrennanConroy removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 7, 2024
@BrennanConroy BrennanConroy merged commit 2287c78 into dotnet:main Oct 7, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 7, 2024
julealgon
julealgon reviewed Oct 7, 2024
View reviewed changes
Copy link

@julealgon julealgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the team has opted for the reordering solution. While I personally don't think this was the best approach, it does solve the underlying problem.

captainsafia pushed a commit that referenced this pull request Dec 31, 2024
@mkArtakMSFT @captainsafia
Remove area- assignment rule as we now rely on dotnet-issue-labeler t…
7d79b50 
…o handle this (#57775)

Without this change many PRs were getting labeled with duplicate labels and this automation was very invasive, as the labelers were getting added even after removing some labels manually. Here is an example PR where I've noticed this: #55847
captainsafia pushed a commit that referenced this pull request Dec 31, 2024
@feiyun0112 @captainsafia
[OutputCaching] OutputCacheOptions.ApplicationServices is always null…
f667527 
… during initialization (#55847)
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@mkArtakMSFT @captainsafia
Remove area- assignment rule as we now rely on dotnet-issue-labeler t…
92e9ea4 
…o handle this (#57775)

Without this change many PRs were getting labeled with duplicate labels and this automation was very invasive, as the labelers were getting added even after removing some labels manually. Here is an example PR where I've noticed this: #55847
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@feiyun0112 @captainsafia
[OutputCaching] OutputCacheOptions.ApplicationServices is always null…
da56563 
… during initialization (#55847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julealgon julealgon julealgon left review comments

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.

[OutputCaching] OutputCacheOptions.ApplicationServices is always null during initialization
5 participants
@feiyun0112 @julealgon @BrennanConroy @adityamandaleeka @mkArtakMSFT