Revert "Quarantine flaky MVC functional tests (#55935)" #56615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06c2466.
ghost
added
the
area-mvc
Do we know if any explicit action have been taken to resolve any of these? |
No, which is why the second sentence says why I want to unquarantine. |
Won't we still be able to get logs even if they are quarantined? Or is your motivation to make the failures more obvious to us so we can investigate using the new logs? |
Yep
|
amcasey
added a commit
that referenced
this pull request
Sep 30, 2024
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 06c2466.
Tests have been passing for a month in quarantine. Normally that doesn't mean they should be removed, but we've added logging to Mvc.FunctionalTests since then and would like to make the failures (if any) more likely by adding them back to the main runs.