Skip to content

Fix race in RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted #57450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix race in RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted #57450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cdbc7
Unquarantine RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame…
amcasey Aug 22, 2024
c85e78a
Keep test quarantined
amcasey Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3602,10 +3602,11 @@ public async Task RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_Conne
await SendDataAsync(1, new byte[1], endStream: false);
await SendRstStreamAsync(1);
await SendWindowUpdateAsync(1, 1024);
tcs.TrySetResult();

await WaitForConnectionErrorAsync<Http2ConnectionErrorException>(ignoreNonGoAwayFrames: false, expectedLastStreamId: 1,
Http2ErrorCode.STREAM_CLOSED, CoreStrings.FormatHttp2ErrorStreamAborted(Http2FrameType.WINDOW_UPDATE, 1));

tcs.TrySetResult(); // Don't let the response start until after the abort
}

[Fact]
Expand Down
Loading