Skip to content

Readd DiagnosticSource to KestrelServerImpl #60129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

Readd DiagnosticSource to KestrelServerImpl #60129

merged 2 commits into from
Feb 5, 2025

Conversation

BrennanConroy
Copy link
Member

Fixes #58911

Regressed in #46834. Added a little bit more test coverage by checking some properties on KestrelServerImpl.

@BrennanConroy BrennanConroy added feature-kestrel area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Jan 31, 2025
@BrennanConroy BrennanConroy marked this pull request as ready for review January 31, 2025 18:42
@BrennanConroy
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@BrennanConroy BrennanConroy requested a review from Copilot February 1, 2025 00:08
Copilot
Copilot AI reviewed Feb 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@BrennanConroy
Copy link
Member Author

/backport to release/9.0

@BrennanConroy
Copy link
Member Author

/backport to release/8.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/13147213873

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/13147214979

This was referenced Feb 5, 2025
Merged
Merged
@BrennanConroy BrennanConroy merged commit 0ca0136 into main Feb 5, 2025
27 checks passed
@BrennanConroy BrennanConroy deleted the brecon/diagnosticsource branch February 5, 2025 00:04
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@DeagleGross DeagleGross DeagleGross approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell

@adityamandaleeka adityamandaleeka Awaiting requested review from adityamandaleeka

@captainsafia captainsafia Awaiting requested review from captainsafia

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Projects
None yet
Milestone
10.0-preview2
Development

Successfully merging this pull request may close these issues.

KestrelServer Diagnostic Source
2 participants
@BrennanConroy @DeagleGross