Re-quarantine SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded test #63492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
…pIsBeingDiscarded test Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
oroztocil
September 1, 2025 10:51
oroztocil
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR re-quarantines a flaky test by restoring the [QuarantinedTest] attribute that was previously removed. The test SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded has known flakiness issues tracked in GitHub issue #60472, and quarantining it prevents build failures while the underlying issue remains unresolved.
Key changes:
- Restored the
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/60472")]attribute above the flaky test method
oroztocil
approved these changes
Sep 1, 2025
akoeplinger
approved these changes
Sep 1, 2025
javiercn
approved these changes
Sep 1, 2025
|
/ba-g Unrelated CI failure |
oroztocil
deleted the
copilot/fix-9ace6eda-2e59-4dbf-999c-50f2fcdf6c36
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-quarantines the
SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscardedtest method inRevalidatingServerAuthenticationStateProviderTest.csby adding back the[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/60472")]attribute.The test was previously quarantined due to flakiness issues tracked in #60472, but the quarantine attribute was recently removed. This change restores the quarantine to prevent the flaky test from causing build failures until the underlying issue can be properly resolved.
Changes made:
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/60472")]attribute above the test methodThe quarantine format follows the established pattern used by other quarantined tests in the repository.
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.