[Blazor] Skip tests in ThreadingHostedAppTest and ThreadingAppTest #63525
+10
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith Skip attributes Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
javiercn
September 3, 2025 15:43
javiercn
reviewed
Sep 3, 2025
|
|
||
| [Fact] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")] | ||
| [Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")] |
Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates Blazor E2E tests to skip flaky tests by replacing QuarantinedTest attributes with Fact Skip attributes. The change consolidates various test failures under a single GitHub issue (#63524) for better tracking.
- Replaced QuarantinedTest attributes with Fact(Skip = "...") attributes across 10 test methods
- Unified skip messages to reference issue #63524 instead of multiple different issues
- Simplified skip messages to contain only the GitHub URL without additional explanatory text
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Components/test/E2ETest/Tests/ThreadingAppTest.cs | Updated 6 test methods to use skip attributes instead of quarantine attributes |
| src/Components/test/E2ETest/Tests/ThreadingAppHostedTest.cs | Updated 4 test methods to use skip attributes instead of quarantine attributes |
Copilot finished work on behalf of
javiercn
September 3, 2025 16:08
javiercn
approved these changes
Sep 3, 2025
pavelsavara
approved these changes
Sep 3, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/aspnetcore/actions/runs/17459604167 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All skip messages now contain only
"https://github.com/dotnet/aspnetcore/issues/63524"as requested in the code review feedback.Fixes #63524.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.