Fix RouteHandlerAnalyzer to avoid exception when generic type parameter is used in a handler #63641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-infrastructure
dotnet-policy-service
bot
added
the
community-contribution
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #56831
Changes
In
RouteHandlerAnalyzernull-forgiving operator is used incorrectly onparameterTypeSymbolvariable becauseparameterTypeSymbolmay be null. For example, it is null in the case whenparameterSymbol.Typeis a generic type parameter. Fixed this by just replacing it with null-conditional operator.Added
[StringSyntax]attribute inCSharpAnalyzerVerifier<TAnalyzer>.VerifyAnalyzerAsyncto enable syntax highlighting for test source code. I actually decided to suggest a separate PR for that [Proposal] Analyzer test readability improvements #63642Added a unit test.