-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/10.0] Load handler DLL with load dir on the path #63781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adityamandaleeka is this for RC2 or RTM? |
@wtgodbe it is for RC2 if possible (see Jeff's tactics mail about speculative changes). Given the change is so localized, my inclination would be to get it into RC2 if we're allowed to today, even though vendor validation didn't yet happen. |
Mechanistically should we kick the bot to make an rc2 port, or do you do that? |
/backport to release/10.0-rc2 |
Started backporting to release/10.0-rc2: https://github.com/dotnet/aspnetcore/actions/runs/17981742507 |
Sounds good, I just kicked the bot. Since this is already green we might as well merge it too |
Hi @@github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Backport of #63773 to release/10.0
/cc @adityamandaleeka
Load handler DLL with load dir on the path
Description
This change updates the handler DLL load call from
LoadLibrary
toLoadLibraryEx
with the flagsLOAD_LIBRARY_SEARCH_DEFAULT_DIRS | LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR
The handler DLL exports
CreateApplication
as a forwarded export to an architecture-specific DLL. The plainLoadLibrary
does not search the handler’s directory when resolving that forwarder. As a result, the loader fails to locate the arch-specific DLL and the scenario breaks (the user gets a 500 error).Fixes #63772
Customer Impact
Apps may fail to start because the arch-specific implementation for the forwarded export isn't found.
Regression?
This bug was introduced in .NET 10 Preview 2 as part of #59483
Risk
Localized change to one load site. Only adds the handler's directory to the probing path for that module's dependency resolution and does not enable PATH/CWD, nor change process-wide state.
Verification
Packaging changes reviewed?