Skip to content

[release/10.0] (http2): Lower WINDOWS_UPDATE received on (half)closed stream to stream abortion #63885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+10 −5
Merged

[release/10.0] (http2): Lower WINDOWS_UPDATE received on (half)closed stream to stream abortion #63885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c0f919
change WINDOWS_UPDATE received on (half)closed stream to stream-level…
DeagleGross Sep 29, 2025
58e51a0
address PR comments
DeagleGross Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,8 +1158,12 @@ private Task ProcessWindowUpdateFrameAsync()
{
if (stream.RstStreamReceived)
{
// Hard abort, do not allow any more frames on this stream.
throw CreateReceivedFrameStreamAbortedException(stream);
// WINDOW_UPDATE received after we have already processed an inbound RST_STREAM for this stream.
// RFC 7540 (Sections 5.1, 6.9) / RFC 9113 do not explicitly define semantics for WINDOW_UPDATE on a
// stream in the "closed" state due to a reset by client. We surface it as a stream error (STREAM_CLOSED)
// rather than aborting the entire connection to keep behavior deterministic and consistent with other servers.
// https://github.com/dotnet/aspnetcore/issues/63726
throw new Http2StreamErrorException(_incomingFrame.StreamId, CoreStrings.Http2StreamAborted, Http2ErrorCode.STREAM_CLOSED);
}

if (!stream.TryUpdateOutputWindow(_incomingFrame.WindowUpdateSizeIncrement))
Expand Down
7 changes: 4 additions & 3 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3599,7 +3599,6 @@ public async Task RST_STREAM_IncompleteRequest_AdditionalResetFrame_IgnoreAdditi
AssertConnectionNoError();
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/53744")]
[Fact]
public async Task RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted()
{
Expand All @@ -3618,10 +3617,12 @@ public async Task RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_Conne
await SendRstStreamAsync(1);
await SendWindowUpdateAsync(1, 1024);

await WaitForConnectionErrorAsync<Http2ConnectionErrorException>(ignoreNonGoAwayFrames: false, expectedLastStreamId: 1,
Http2ErrorCode.STREAM_CLOSED, CoreStrings.FormatHttp2ErrorStreamAborted(Http2FrameType.WINDOW_UPDATE, 1));
await WaitForStreamErrorAsync(expectedStreamId: 1, Http2ErrorCode.STREAM_CLOSED, CoreStrings.Http2StreamAborted);

tcs.TrySetResult(); // Don't let the response start until after the abort

await StopConnectionAsync(expectedLastStreamId: 1, ignoreNonGoAwayFrames: false);
AssertConnectionNoError();
}

[Fact]
Expand Down
Loading