Skip to content

Conversation

medhatiwari
Copy link
Contributor

Fix ResponseCompression tests for system zlib compatibility

Fixes #63969

Changes

  • Replace exact byte count assertions with functional decompression verification in CheckResponseCompressed
  • Add CheckCompressionFunctionality method to verify compression by decompressing content
  • Update HTTPS test methods to use appropriate verification based on compression state
  • Handle edge cases: HEAD requests, NoCompression, and SendFileAsync scenarios

Testing

All existing tests pass with both zlib-ng and system zlib implementations.

cc: @giritrivedi

@github-actions github-actions bot added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Oct 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 10, 2025
Copy link
Contributor

Thanks for your PR, @@medhatiwari. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResponseCompression tests should verify functionality, not exact compressed byte counts

1 participant