Skip to content

Enable logging branch SiteExtension #6715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jan 15, 2019

We are servicing Azure Logger provider and need to rebuild branch site extension.

@pakrym pakrym requested a review from natemcmaster January 15, 2019 18:56
@natemcmaster natemcmaster requested a review from dougbu January 15, 2019 19:46
@dougbu
Copy link
Contributor

dougbu commented Jan 15, 2019

To confirm: This PR doesn't need any new packages to be listed in PatchConfig.props?

@pakrym
Copy link
Contributor Author

pakrym commented Jan 15, 2019

Honestly, I'm not sure, site extension build produces a package but it's not our usual product .nupkg and is more similar to shared runtime packages in nature and is done in a separate build step.

What does PatchConfig affect?

@dougbu
Copy link
Contributor

dougbu commented Jan 15, 2019

What does PatchConfig affect?

As I understand it, this file affects what's included in the "slim" version of the patch Zip for incremental patch updates as well as the packages we actually ship. @natemcmaster is that correct?

@natemcmaster
Copy link
Contributor

PatchConfig affects all projects which import Directory.Build.props/targets. It is used to determine whether or not to produce a new .nupkg.

Site extension is still special in this branch of the build system. Run the build locally and double check that you get the build artifacts you expect.

@pakrym pakrym merged commit f44c175 into release/2.2 Jan 16, 2019
@natemcmaster natemcmaster deleted the pakrym/enable-site-extensions branch January 18, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants