Copy Kestrel perf changes #7480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Feb 12, 2019
jkotalik
reviewed
Feb 12, 2019
| using System.Runtime.CompilerServices; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Microsoft.AspNetCore.Internal |
There was a problem hiding this comment.
Not a fan of this namespace. Is this appropriate?
davidfowl
reviewed
Feb 12, 2019
JamesNK
reviewed
Feb 12, 2019
| <Compile Include="$(SignalRSharedSourceRoot)PipeWriterStream.cs" Link="PipeWriterStream.cs" /> | ||
| <Compile Include="$(SignalRSharedSourceRoot)ReflectionHelper.cs" Link="ReflectionHelper.cs" /> | ||
| <Compile Include="$(SignalRSharedSourceRoot)TimerAwaitable.cs" Link="Internal\TimerAwaitable.cs" /> | ||
| <Compile Include="$(SignalRSharedSourceRoot)ValueTaskExtensions.cs" Link="Internal\ValueTaskExtensions.cs" /> |
There was a problem hiding this comment.
IMO instead of placing this code under SignalR's shared source directory, it should be under the repos shared source directory: src/Shared -> https://github.com/aspnet/AspNetCore/tree/master/src/Shared
That way Kestrel and SignalR can use the same copy of code. There is no overhead of creating a source package because we mono repo now.
There was a problem hiding this comment.
Do it in another PR. I don't care that much.
There was a problem hiding this comment.
You can apply the same optimization to the SignalR client in the class ServerSentEventsMessageParser with the fields _dataPrefix and _sseLineEnding .
davidfowl
approved these changes
Feb 13, 2019
halter73
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7468 and #7422