Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

build.cmd should always check for NuGet package updates #136

Merged
merged 1 commit into from Jun 19, 2015
Merged

build.cmd should always check for NuGet package updates #136

merged 1 commit into from Jun 19, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2015

build.cmd was skipping the NuGet restore command if the
src\packages directory existed at all, regardless of what
was in it. As a result, the command line build would fail
whenever we updated a package (as, for example, I did
yesterday in updating to Roslyn 1.0.0-rc3).

Modify build.cmd to restore packages unconditionally. The
fraction of a second it takes to discover that all packages
are up to date is not significant.

@srivatsn @jaredpar

build.cmd was skipping the NuGet restore command if the
src\packages directory existed at all, regardless of what
was in it. As a result, the command line build would fail
whenever we updated a package (as, for example, I did
yesterday in updating to Roslyn 1.0.0-rc3).

Modify build.cmd to restore packages unconditionally. The
fraction of a second it takes to discover that all packages
are up to date is not significant.
@ghost ghost assigned jaredpar Jun 19, 2015
@ghost ghost assigned Priya91 and unassigned jaredpar Jun 19, 2015
@srivatsn
Copy link

LGTM

@Priya91
Copy link
Contributor

Priya91 commented Jun 19, 2015

👍

Priya91 added a commit that referenced this pull request Jun 19, 2015
build.cmd should always check for NuGet package updates
@Priya91 Priya91 merged commit 878c464 into dotnet:master Jun 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants