This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Bug fixes #43
Merged
Bug fixes #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straw man design for the problem being discussed in issue #38. Essentially let the developer specify on the command line what configurations they want the code to be formatted under. This is much safer than assuming all configurations in the file are valid.
This adds tests for how we handle preprocessor directives with respect to file formatting. closes #38
Consider the following code:
``` csharp
void M()
{
G();
// Comment
}
```
The new line between G() and the comment is meaningful and should be
kept by the tool. This change fixes that and a couple of subtle issues
around white spaces and new lines.
closes #36
While plumbing through a CancellationToken I noticed that IFormattingFilter had no async implementations. Made it sync until an actual async version is needed.
Moved the checks for the existance of the file and having a non-readonly nature to an actual IFormattingFilter instance.
This change adds the preprocessor symbol DOTNET_FORMATTER to every project in the formatted Solution. This allows developers to exempt code from formatting by surrounding blocks with ``` csharp #if !DOTNET_FORMATTER ``` This should only be done on the rare occasions where insignificant white space serves to make the code significantly more readable. For example in large unicode tables. In general this feature should be avoided. closes #37
|
@nslottow if code wants to exist solely for the code formatter they could change I'm truthfully not very concerned about the |
Conflicts: src/CodeFormatter/Program.cs src/Microsoft.DotNet.CodeFormatting/IFormattingEngine.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of bug fixes for the formatter.