How to add support for new RIDs? #2599
Labels
area-Infrastructure-installer
question
Answer questions and provide assistance, not an issue with source code or documentation.
Milestone
Comments
omajid
changed the title
|
@weshaggard Should be able to help. |
|
CC @ericstj |
|
@omajid it looks like you're building an old branch of core-setup. Which branch is it you're trying to build? master is the only branch picking up new builds of CoreFx. |
|
I am building |
|
That's interesting, nowhere is that version |
|
I just tried again from a fresh clone. Here's what I did. Please let me know if there's something else that I should remove to avoid any stale artifacts from older builds leaking through. |
|
You've truncated the portion of interest. Before those errors there should be a text that indicates which project is being restored and which sources are used. Can you please put the whole log up on https://gist.github.com/? /cc @chcosta and @ellismg who have both been looking into making the build work without changes on new distros. |
|
Added the full output of |
|
I see, its failing when restoring all the build_projects. These are running as standalone apps and will fail if they don't have your new RID mapping. I believe @AlfredoMS's work to refactor this part of the build will fix a lot of these. In the meantime we can try to limp along by upgrading these projects and including the latest RID graph. I've given this a try in this branch: https://github.com/ericstj/core-setup/tree/updateBuildProjects I don't have a good way of testing if I've gotten everything. This is just a bunch of throw away code, as I believe @AlfredoMS's work will delete most of these problem projects. |
|
Yep, I'm working on https://github.com/dotnet/core-setup/issues/283 and that will make it more straightforward. |
|
@ericstj Thanks! Unfortunately, I didn't get much further with that. Now Should I keep this bug open or close it as a dupe of #2479? |
|
I've added a new commit. ericstj/core-setup@c2bdc5c Essentially for any project that fails in this way, make sure it has an updated copy of Microsoft.NETCore.Platforms. Ideally we'd also make sure it's on a consistent set of dependencies (eg: NETCoreApp 1.1 release). Core-setup hasn't seen the same sort of diligence here as other repos. Whether or not we wait for #2479 or try to push this through depends on your timeline. Not sure when #2479 is going to be done. |
|
@ellismg Hey, does the new source-build stuff need support for new RIDs the way I am trying to add it here? The way I am doing this is to add the new RIDs in If this RID support not needed by source-build, I have no urgency for this issue, though it would be nice to keep .NET Core building when users do a general package update on RHEL 7, which goes from RHEL 7.2 to 7.3. |
The composed build will take care of both adding the target rid to Microsoft.NETCore.Platforms and updating the runtimes sections of project.jsons as we go up the stack. In addition, we'll "roll forward" and package references during a composed build (so if Core-Setup already had a reference to Microsoft.NETCore.Platforms somehow (or it was brought in transitively by some other package) you would get the newer version. |
|
Thanks. I guess I will wait until #2479 lands. |
|
Closing: it looks like a lot was answered here and the issue is fairly stale. Please open any further questions in dotnet/runtime if there are any, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I pushed a fix to corefx (dotnet/corefx@68c0368) to add support for some additional runtimes. I am trying to build core-setup now and it still isn't picking up the additional runtimes. My builds fail with some variant of:
Can you please point me to some doc or an example of how do add support for an additional runtime to core-setup? Does it involving bumping the versions of corefx being used? Or is there some way to teach core-setup to augment the runtime ids some other way?
Apologies in advance if this is a really basic question but I couldn't find an answer to it.
The text was updated successfully, but these errors were encountered: