New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reading of host_interface_t to be backwards compatible. #1818

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
4 participants
@AustinWise
Contributor

AustinWise commented Mar 22, 2017

PR #1727 added some new fields to host_interface_t but did not correctly check the size of the struct before reading the fields.

Fix the reading of host_interface_t to be backwards compatible.
PR #1727 added some new fields to host_interface_t but did not correctly
check the size of the struct before reading the fields.
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Mar 22, 2017

@AustinWise,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Mar 22, 2017

@AustinWise,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@eerhardt

This comment has been minimized.

Show comment
Hide comment
@eerhardt
Member

eerhardt commented Mar 23, 2017

@gkhanna79

Good catch - thanks for fixing this!

@gkhanna79 gkhanna79 merged commit c04f2ca into dotnet:master Mar 23, 2017

14 checks passed

CentOS7.1 x64 Debug Build Build finished.
Details
Debian8.2 x64 Debug Build Build finished.
Details
Fedora23 x64 Debug Build Build finished.
Details
OSX10.12 x64 Release Build Build finished.
Details
OpenSUSE42.1 x64 Debug Build Build finished.
Details
PortableLinux x64 Release Build Build finished.
Details
RHEL7.2 x64 Release Build Build finished.
Details
Ubuntu arm Release Build Build finished.
Details
Ubuntu x64 Release Build Build finished.
Details
Ubuntu16.04 x64 Release Build Build finished.
Details
Ubuntu16.10 x64 Release Build Build finished.
Details
Windows_NT arm Debug Build Build finished.
Details
Windows_NT x64 Release Build Build finished.
Details
Windows_NT x86 Debug Build Build finished.
Details

@AustinWise AustinWise deleted the AustinWise:fixBackwardsCompatOfHostInterfaceT branch Mar 23, 2017

@AustinWise

This comment has been minimized.

Show comment
Hide comment
@AustinWise

AustinWise Mar 23, 2017

Contributor

@gkhanna79 Not a problem, thanks for making this open source! It's fun to follow along and also I get some good ideas to improve code quality at work.

Contributor

AustinWise commented Mar 23, 2017

@gkhanna79 Not a problem, thanks for making this open source! It's fun to follow along and also I get some good ideas to improve code quality at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment