API diff between .NET 7 and .NET 8 #8921

carlossanlop · 2023-11-15T04:54:08Z

Repos area owners:

ASP.NET - @dotnet/aspnet-api-review
WinForms - @merriemcgaw @dreddy-work @JeremyKuhne
WPF - @singhashish-wpf and @pchaurasia14
Libraries - @artl93 @jeffhandley @karelz @ericstj @stephentoub

Libraries area owners:

@dotnet/area-system-runtime
@dotnet/area-system-buffers
@dotnet/area-system-codedom
@dotnet/area-system-collections
@dotnet/area-system-componentmodel
@dotnet/area-system-componentmodel-dataannotations
@dotnet/area-system-componentmodel-composition
System.Data: @ajcvickers @DavoudEshtehari @David-Engel @roji
@dotnet/area-system-diagnostics-activity
@dotnet/area-system-diagnostics-eventlog
System.Diagnostics.Metrics: @tommcdon @noahfalk
@dotnet/area-system-formats-asn1
@dotnet/area-system-globalization
@dotnet/area-system-io @tmds
@dotnet/area-system-io-compression
@dotnet/area-system-linq
System.Net: @dotnet/ncl
@dotnet/area-system-numerics
@dotnet/area-system-reflection
@dotnet/area-system-reflection-emit
@dotnet/area-system-reflection-metadata
@dotnet/area-system-resources
@dotnet/area-system-runtime-compilerservices
System.Runtime.InteropServices: @dotnet/interop-contrib
System.Runtime.InteropServices.Javascript: @lewing @pavelsavara
@dotnet/area-system-runtime-intrinsics
System.Runtime.Intrinsics.Wasm: @lewing @steveisok @thaystg @radical @akoeplinger @lambdageek
@dotnet/area-system-security
@dotnet/area-system-text-encoding
@dotnet/area-system-text-json
@dotnet/area-system-text-regularexpressions
System.Threading: @mangod9 @kouvel
@dotnet/area-system-threading-channels
@dotnet/area-system-threading-tasks
System.Transactions: @ajcvickers @roji
@dotnet/area-system-xml

Known api-diff tool issues:

The AsmDiff tool sometimes skips adding { or {}. Please provide a GitHub suggestion in this PR so I can correct it. arcade#10981
The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect. I have an issue to track this: arcade#13814

adamsitnik

System.IO, System.IO.Pipes and System.IO.MemoryMappedFiles LGTM 👍

singhashish-wpf

wpf LGTM

pavelsavara

System.Runtime.InteropServices.JavaScript LGTM

roji

System.Data and System.Data.Common LGTM
For System.Data.SqlTypes, /cc @David-Engel

tannergooding · 2023-11-15T15:44:04Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Buffers.Binary.md

@@ -0,0 +1,78 @@
+# System.Buffers.Binary


System.Buffers.Binary LGTM

Primarily adding support for Int128/UInt128, IntPtr/UIntPtr, and support for reversing endianness of entire spans.

CC. @dotnet/area-system-buffers

tannergooding · 2023-11-15T15:44:48Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Buffers.Text.md

@@ -0,0 +1,13 @@
+# System.Buffers.Text


System.Buffers.Text LGTM

CC. @dotnet/area-system-buffers

tannergooding · 2023-11-15T15:45:20Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Buffers.md

@@ -0,0 +1,26 @@
+# System.Buffers


System.Buffers LGTM

Primarily the new SearchValues support

CC. @dotnet/area-system-buffers

tannergooding · 2023-11-15T15:48:50Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Numerics.md

@@ -0,0 +1,247 @@
+# System.Numerics


System.Numerics LGTM

This is namely support for IUtf8SpanFormattable/IUtf8SpanParsable, an iterative Crc32C primitive, Lerp, DegreesToRadians, RadiansToDegrees, left-handed matrix creation functions, and removing the where T : struct contstraint from Vector<T> so it can more easily be used in generic contexts (this does not expand the set of supported T).

CC. @dotnet/area-system-numerics

tannergooding · 2023-11-15T15:50:14Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.CompilerServices.md

@@ -0,0 +1,123 @@
+# System.Runtime.CompilerServices


System.Runtime.CompilerServices LGTM

Namely new attributes to support language features and remove the need for the compiler to emit internal copies in every assembly. But also some changes to use ref readonly where applicable

CC. @dotnet/area-system-runtime-compilerservices

tannergooding · 2023-11-15T15:50:44Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.CompilerServices.md

+     }
+     public static class Unsafe {
+-        public static bool AreSame<T>([AllowNullAttribute] ref T left, [AllowNullAttribute] ref T right);
+        public static bool AreSame<T>([AllowNullAttribute, RequiresLocationAttribute] ref T left, [AllowNullAttribute, RequiresLocationAttribute] ref T right);


@carlossanlop, [RequiresLocation] ref T should be emitted as ref readonly in the diff

Opened an issue to track this request: dotnet/arcade#14238

tannergooding · 2023-11-15T15:51:48Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.InteropServices.md

+        public static void Write<T>(Span<byte> destination, in T value) where T : struct;
+     }
+-    public readonly struct NFloat : IAdditionOperators<NFloat, NFloat, NFloat>, IAdditiveIdentity<NFloat, NFloat>, IBinaryFloatingPointIeee754<NFloat>, IBinaryNumber<NFloat>, IBitwiseOperators<NFloat, NFloat, NFloat>, IComparable, IComparable<NFloat>, IComparisonOperators<NFloat, NFloat, bool>, IDecrementOperators<NFloat>, IDivisionOperators<NFloat, NFloat, NFloat>, IEqualityOperators<NFloat, NFloat, bool>, IEquatable<NFloat>, IExponentialFunctions<NFloat>, IFloatingPoint<NFloat>, IFloatingPointConstants<NFloat>, IFloatingPointIeee754<NFloat>, IFormattable, IHyperbolicFunctions<NFloat>, IIncrementOperators<NFloat>, ILogarithmicFunctions<NFloat>, IMinMaxValue<NFloat>, IModulusOperators<NFloat, NFloat, NFloat>, IMultiplicativeIdentity<NFloat, NFloat>, IMultiplyOperators<NFloat, NFloat, NFloat>, INumber<NFloat>, INumberBase<NFloat>, IParsable<NFloat>, IPowerFunctions<NFloat>, IRootFunctions<NFloat>, ISignedNumber<NFloat>, ISpanFormattable, ISpanParsable<NFloat>, ISubtractionOperators<NFloat, NFloat, NFloat>, ITrigonometricFunctions<NFloat>, IUnaryNegationOperators<NFloat, NFloat>, IUnaryPlusOperators<NFloat, NFloat> {
+    public readonly struct NFloat : IAdditionOperators<NFloat, NFloat, NFloat>, IAdditiveIdentity<NFloat, NFloat>, IBinaryFloatingPointIeee754<NFloat>, IBinaryNumber<NFloat>, IBitwiseOperators<NFloat, NFloat, NFloat>, IComparable, IComparable<NFloat>, IComparisonOperators<NFloat, NFloat, bool>, IDecrementOperators<NFloat>, IDivisionOperators<NFloat, NFloat, NFloat>, IEqualityOperators<NFloat, NFloat, bool>, IEquatable<NFloat>, IExponentialFunctions<NFloat>, IFloatingPoint<NFloat>, IFloatingPointConstants<NFloat>, IFloatingPointIeee754<NFloat>, IFormattable, IHyperbolicFunctions<NFloat>, IIncrementOperators<NFloat>, ILogarithmicFunctions<NFloat>, IMinMaxValue<NFloat>, IModulusOperators<NFloat, NFloat, NFloat>, IMultiplicativeIdentity<NFloat, NFloat>, IMultiplyOperators<NFloat, NFloat, NFloat>, INumber<NFloat>, INumberBase<NFloat>, IParsable<NFloat>, IPowerFunctions<NFloat>, IRootFunctions<NFloat>, ISignedNumber<NFloat>, ISpanFormattable, ISpanParsable<NFloat>, ISubtractionOperators<NFloat, NFloat, NFloat>, ITrigonometricFunctions<NFloat>, IUnaryNegationOperators<NFloat, NFloat>, IUnaryPlusOperators<NFloat, NFloat>, IUtf8SpanFormattable, IUtf8SpanParsable<NFloat> {


NFloat LGTM.

Simply implementing the new APIs added to the generic math interfaces (utf8 parse/format, lerp, deg2rad, rad2deg, etc).

off topic, does NFloat deserve mention in https://learn.microsoft.com/en-us/dotnet/standard/native-interop/best-practices ? I had overlooked it, but it's seems like it's more niche than nint and nuint. Perhaps that doc ought to have a new table for mappings to Apple things like CGFloat.

tannergooding · 2023-11-15T15:52:43Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.Intrinsics.Arm.md

@@ -0,0 +1,1352 @@
+# System.Runtime.Intrinsics.Arm


System.Runtime.Intrinsics.Arm LGTM

Namely adding the [ConstantExpected] attribute, but also a few new APIs covering the multiple register load/store instructions.

CC. @dotnet/area-system-runtime-intrinsics

tannergooding · 2023-11-15T15:54:12Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.Intrinsics.Wasm.md

@@ -0,0 +1,482 @@
+# System.Runtime.Intrinsics.Wasm


System.Runtime.Intrinsics.Wasm LGTM

CC. @dotnet/area-system-runtime-intrinsics, @radekdoulik

tannergooding · 2023-11-15T15:55:23Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.Intrinsics.X86.md

@@ -0,0 +1,1612 @@
+# System.Runtime.Intrinsics.X86


System.Runtime.Intrinsics.X86 LGTM

This is the addition of the [ConstantExpected] attribute and the new AVX-512 surface area (Avx512F, Avx512BW, Avx512CD, Avx512DQ, Avx512Vbmi, etc).

CC. @dotnet/area-system-runtime-intrinsics

tannergooding · 2023-11-15T15:56:32Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Runtime.Intrinsics.md

@@ -0,0 +1,974 @@
+# System.Runtime.Intrinsics


System.Runtime.Intrinsics LGTM

This is namely the removal of the where T : struct constraint for easier use in generic contexts (this does not expand the set of supported T) and the addition of the Vector512<T> type

CC. @dotnet/area-system-runtime-intrinsics

tannergooding · 2023-11-15T16:02:18Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.md

@@ -0,0 +1,841 @@
+# System


System LGTM

This is namely obsoleting binary-formatter APIs, but also various other additions such as implementing the new generic math APIs (utf8 parse/format, lerp, deg2rad, rad2deg, etc), addition of more throw helpers on ArgumentOutOfRangeException (ThrowIfZero, ThrowIfNegative, ThrowIfEqual, ThrowIfGreaterThan, etc), a number of new Span/ReadOnlySpan APIs for searching or finding data (ContainsAny, ContainsAnyExcept, CointainsAnyInRange, Count, IndexOfAny, IndexOfAnyExcept, LastIndexOf, Split, etc), and new Random APIs in the form of GetItems and Shuffle

CC. @dotnet/area-system-runtime

tommcdon · 2023-11-15T16:08:05Z

System.Diagnostics.Metrics

Adding @tarekgh

eiriktsarpalis

Collection and STJ namespaces LGTM.

David-Engel

System.Data.SqlTypes LGTM

tarekgh · 2023-11-15T17:43:16Z

release-notes/8.0/8.0.0/api-diff/Microsoft.NETCore.App/8.0.0_System.Globalization.md

+``` diff
+ namespace System.Globalization {
+     public class CultureNotFoundException : ArgumentException {
+-        protected CultureNotFoundException(SerializationInfo info, StreamingContext context);


protected CultureNotFoundException(SerializationInfo info, StreamingContext context);

Is this how to show diff for methods which got a new attributes?

Unfortunately yes, it's weird, I know.

kouvel · 2023-11-15T17:48:26Z

System.Threading LGTM

tarekgh · 2023-11-15T18:00:29Z

The following LGTM.

8.0.0_System.Diagnostics.Metrics.md
8.0.0_System.Globalization.md
8.0.0_System.md (Date/time stuff)
8.0.0_System.Text.md
8.0.0_Microsoft.Extensions.Configuration.md
8.0.0_Microsoft.Extensions.Configuration.Xml.md
8.0.0_Microsoft.Extensions.Diagnostics.Metrics.Configuration.md
8.0.0_Microsoft.Extensions.Diagnostics.Metrics.md
8.0.0_Microsoft.Extensions.Logging.Console.md
8.0.0_Microsoft.Extensions.Logging.md
8.0.0_Microsoft.Extensions.Primitives.md

merriemcgaw · 2023-11-21T00:23:11Z

@JeremyKuhne @lonitra for WinForms.

carlossanlop added 4 commits November 14, 2023 20:39

README.md

df011de

AspNetCore

5e71aad

NETCore

adae90d

WindowsDesktop

f971538

carlossanlop self-assigned this Nov 15, 2023

carlossanlop requested review from rbhanda and leecow as code owners November 15, 2023 04:54

adamsitnik approved these changes Nov 15, 2023

View reviewed changes

singhashish-wpf approved these changes Nov 15, 2023

View reviewed changes

pavelsavara approved these changes Nov 15, 2023

View reviewed changes

roji approved these changes Nov 15, 2023

View reviewed changes

tannergooding reviewed Nov 15, 2023

View reviewed changes

tannergooding approved these changes Nov 15, 2023

View reviewed changes

eiriktsarpalis approved these changes Nov 15, 2023

View reviewed changes

David-Engel approved these changes Nov 15, 2023

View reviewed changes

tarekgh reviewed Nov 15, 2023

View reviewed changes

leecow approved these changes Nov 16, 2023

View reviewed changes

carlossanlop mentioned this pull request Nov 27, 2023

[AsmDiff] [RequiresLocationAttribute] ref T should be emitted as ref readonly in the API diff dotnet/arcade#14238

Open

carlossanlop merged commit 788ae8c into dotnet:main Nov 27, 2023
3 checks passed

carlossanlop deleted the ApiDiff7vs8 branch November 27, 2023 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API diff between .NET 7 and .NET 8 #8921

API diff between .NET 7 and .NET 8 #8921

carlossanlop commented Nov 15, 2023

adamsitnik left a comment

singhashish-wpf left a comment

pavelsavara left a comment

roji left a comment

tannergooding Nov 15, 2023 •

edited

Loading

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

carlossanlop Nov 27, 2023

tannergooding Nov 15, 2023

danmoseley Nov 17, 2023 •

edited

Loading

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tannergooding Nov 15, 2023

tommcdon commented Nov 15, 2023 •

edited

Loading

eiriktsarpalis left a comment

David-Engel left a comment

tarekgh Nov 15, 2023

carlossanlop Nov 27, 2023

kouvel commented Nov 15, 2023

tarekgh commented Nov 15, 2023

merriemcgaw commented Nov 21, 2023

API diff between .NET 7 and .NET 8 #8921

API diff between .NET 7 and .NET 8 #8921

Conversation

carlossanlop commented Nov 15, 2023

adamsitnik left a comment

Choose a reason for hiding this comment

singhashish-wpf left a comment

Choose a reason for hiding this comment

pavelsavara left a comment

Choose a reason for hiding this comment

roji left a comment

Choose a reason for hiding this comment

tannergooding Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danmoseley Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tommcdon commented Nov 15, 2023 • edited Loading

eiriktsarpalis left a comment

Choose a reason for hiding this comment

David-Engel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kouvel commented Nov 15, 2023

tarekgh commented Nov 15, 2023

merriemcgaw commented Nov 21, 2023

tannergooding Nov 15, 2023 •

edited

Loading

danmoseley Nov 17, 2023 •

edited

Loading

tommcdon commented Nov 15, 2023 •

edited

Loading