Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SOS and lldb plugin from the coreclr repo #12524

Closed
mikem8361 opened this issue Apr 18, 2019 · 4 comments
Closed

Remove SOS and lldb plugin from the coreclr repo #12524

mikem8361 opened this issue Apr 18, 2019 · 4 comments
Assignees
Milestone

Comments

@mikem8361
Copy link
Member

SOS and the lldb plugin now live in the diagnostics repo. We are almost ready to remove them from the coreclr repo probably in the Preview 6 time frame.

We are still waiting for the new SOS to shipping with the next public release of the Windows debugger (windbg) and there are still some OS/architecture holes in the diagnostics repo's build (and test) matrix (i.e. arm, arm64, FreeBSD, etc.).

@mikem8361 mikem8361 self-assigned this Apr 18, 2019
@stephentoub
Copy link
Member

@tommcdon removed this from the 3.0 milestone

Does this mean an SOS built out of the coreclr repo is going to ship in 3.0? If so, I want to port from the diagnostics repo some changes that were made only there when it was stated that SOS would not ship out of dotnet/coreclr in 3.0.

@mikem8361
Copy link
Member Author

I still won't bother with merging the changes into coreclr. The diagnostics repo SOS has a lot of new features and fixes that coreclr doesn't.

I need to discuss this with Tom, but I still do want to remove SOS from coreclr in the Preview 7 timeframe otherwise it will probably ship with 3.0.

@mikem8361
Copy link
Member Author

mikem8361 commented Jun 14, 2019

SOS is ready to remove from the runtime/coreclr repo when:

  • All SOS commands ported and working in diagnostics repo
  • Windows x64, x86 and arm supported and tested
  • Linux x64 supported and tested
  • Linux arm and arm64 supported and tested
  • Linux MUSL based distros (i.e. Alpine) supported
  • Windows SOS published in the internal extension gallery
  • Windows SOS shipped with the latest public/external Windows debugger release
  • Out of band SOS installation for Linux and macOS (dotnet-sos) finished
  • Document how to install SOS on Windows, Linux and macOS
  • Note added to coreclr repo pointing to the diagnostics repo SOS source.
  • Note added to the runtime package (Microsoft.NETCore.App) explaining how to get SOS now.

@tommcdon
Copy link
Member

@mikem8361 I've moved the issue back to 3.0. Thanks for putting together the release checklist!

janvorli referenced this issue in dotnet/coreclr Jun 20, 2019
pull bot referenced this issue in HarrievG/coreclr Jun 20, 2019
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants