-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Revert "Strip out unused reg code. (#10741)" #10983
Conversation
This reverts commit ed4f594.
I undersatnd from @valenis they are looking into adding a simple perf test into the CI system so a total break like this could not get through. |
@dotnet-bot test windows_nt x64 perf please |
@dotnet-bot test Ubuntu arm Cross Release Build (hung) @adiaaida @valenis @brianrob is the perf tests failure unrelated? Or is it the symptom we're trying to fix? |
@danmosemsft Yes. The perf failure is because there are quotes in the title of your PR. I'll look into a fix to harden against that. I've started this job manually to confirm the changes fix our issue: https://ci2.dot.net/job/dotnet_coreclr/job/perf/job/master/job/perf_perflab_Windows_NT_x64_prtest/35/ |
@adiaaida thanks. If that looks good please hit merge if you get a chance before I do. The arm failure is unrelated and it makes sense to ignore it given this is fixing a break. |
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Revert "Strip out unused reg code. (#10741)" Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
This reverts commit ed4f594 (#10741) which @adiaaida has determined via a process of elimination to be the cause of the broken performance runs.
It's not immediately obvious to us why it broke them because we don't know what registry keys it's expecting to read. @adiaaida can provide a repro case to @JeremyKuhne so he can break down his change and figure out the problem. That's probably quicker than debugging all the perf infrastructure.
meantime we want the runs to work.