Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Apr 14, 2017

This reverts commit ed4f594 (#10741) which @adiaaida has determined via a process of elimination to be the cause of the broken performance runs.

It's not immediately obvious to us why it broke them because we don't know what registry keys it's expecting to read. @adiaaida can provide a repro case to @JeremyKuhne so he can break down his change and figure out the problem. That's probably quicker than debugging all the perf infrastructure.

meantime we want the runs to work.

@danmoseley
Copy link
Member Author

I undersatnd from @valenis they are looking into adding a simple perf test into the CI system so a total break like this could not get through.

@michellemcdaniel
Copy link

@dotnet-bot test windows_nt x64 perf please

@danmoseley
Copy link
Member Author

danmoseley commented Apr 15, 2017

@dotnet-bot test Ubuntu arm Cross Release Build (hung)

@adiaaida @valenis @brianrob is the perf tests failure unrelated? Or is it the symptom we're trying to fix?

@michellemcdaniel
Copy link

@danmosemsft Yes. The perf failure is because there are quotes in the title of your PR. I'll look into a fix to harden against that.

I've started this job manually to confirm the changes fix our issue: https://ci2.dot.net/job/dotnet_coreclr/job/perf/job/master/job/perf_perflab_Windows_NT_x64_prtest/35/

@danmoseley
Copy link
Member Author

danmoseley commented Apr 15, 2017

@adiaaida thanks. If that looks good please hit merge if you get a chance before I do. The arm failure is unrelated and it makes sense to ignore it given this is fixing a break.

@michellemcdaniel michellemcdaniel merged commit dbc3557 into dotnet:master Apr 15, 2017
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Apr 15, 2017
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@danmoseley danmoseley deleted the revert.jeremy branch April 15, 2017 19:02
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 15, 2017
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
Revert "Strip out unused reg code. (#10741)"

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants