Enable linux perf runs #11905
Enable linux perf runs #11905
Conversation
…sts. - Due to this issue: microsoft/xunit-performance#231, we are blocked from running on performance tests on Linux. The tag is not used by infrastructure and it is passed during runtime when profiling on Windows.
jorive
requested review from
dpodder,
brianrob,
DrewScoggins,
AndyAyersMS and
valenis
tests/scripts/run-xunit-perf.sh
Outdated
| echo "----------" | ||
| echo " Running $testname" | ||
| echo "----------" | ||
| run_command $stabilityPrefix ./corerun PerfHarness.dll $test --perf:runid Perf --perf:collect stopwatch || exit 1 |
There was a problem hiding this comment.
This hardcodes --perf:collect and stopwatch, ignoring the input parameters passed to this script. Is that intentional? #Closed
|
It feels wrong to me to remove the However, I'm not going to hold up the PR over this, since I'd like to get the Linux measurements unblocked. Are you able to trigger perf runs pre-merge and verify they produce the expected data, or are we held hostage to lagging visibility of changes to perf.groovy? |
|
@AndyAyersMS |
|
@AndyAyersMS I was able to run the benchmarks offline, and I am in the process to add a new machine to Jenkins (Old machine hardware died), so I can tests the E2E scenario and validate. |
|
test ci please |
|
@dotnet-bot test Ubuntu14.04 perf |
|
test ci please |
2 similar comments
|
test ci please |
|
test ci please |
|
@DrewScoggins I just set the maximum number of iterations, on the |
- Removing `[assembly: MeasureInstructionsRetired]` from performance tests. - Due to this issue: microsoft/xunit-performance#231, we are blocked from running on performance tests on Linux. The tag is not used by infrastructure and it is passed during runtime when profiling on Windows. - Adding the option to execute CoreRun with the stability prefix. - Moving file to be archived by Jenkins and updating groovy file. - Setting the maximum number of iterations.
* Enable linux perf runs (#11905) - Removing `[assembly: MeasureInstructionsRetired]` from performance tests. - Due to this issue: microsoft/xunit-performance#231, we are blocked from running on performance tests on Linux. The tag is not used by infrastructure and it is passed during runtime when profiling on Windows. - Adding the option to execute CoreRun with the stability prefix. - Moving file to be archived by Jenkins and updating groovy file. - Setting the maximum number of iterations. * Updating version of xUnit-Performance-Api (#11987) - This update contains a fix for this issue: microsoft/xunit-performance#230 - Consolidate the Api version in two places: `dependencies.prop` and `PerfHarness.csproj` - Move performance log files to root directory where Jenkins can archive them - Fixed the output to console, so it is easier to see on the Jenkins job the sccript steps live and get an exact repro step if needed
[MeasureInstructionsRetired]attribute from the benchmarks source code, as it's not use, the reason the tests were failing, and this is now passed on the command line when profiling the tests.run-xunit-perf.shandperf.groovyfiles with the appropriate changes.