This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port Fix thread wait to be resilient to real time clock changes on Unix #12033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#11213) This change fixes a problem that happens when a thread uses a timed wait and the real time clock change in the system (e.g. due to the user action, time server sync, leap second, etc). In such case, the wait may end up waiting for shorter or longer period of time. It fixes the issue for Thread.Sleep and timed wait on a process local synchronization primitives by using CLOCK_MONOTONIC instead of CLOCK_REALTIME for waiting on cond vars. Unfortunately, the waits on cross process synchronication primitives like named mutexes always use CLOCK_REALTIME, so this fix works on process local primitives only.
kouvel
approved these changes
Jun 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a problem that happens when a thread uses a timed wait
and the real time clock change in the system (e.g. due to the user action,
time server sync, leap second, etc). In such case, the wait may end up waiting
for shorter or longer period of time.
It fixes the issue for Thread.Sleep and timed wait on a process local synchronization
primitives by using CLOCK_MONOTONIC instead of CLOCK_REALTIME for waiting on
cond vars.
Unfortunately, the waits on cross process synchronication primitives like
named mutexes always use CLOCK_REALTIME, so this fix works on process local primitives
only.