-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Arm64/Unix] Add OfficialBuildRID linux-arm64 #12372
Conversation
@dotnet/arm64-contrib Not sure if this is too soon, but like to hear what is required before this can be merged. One of many steps to resolve #10458 and get cli support on linux-arm64 |
@gkhanna79 @jashook I made the changes to fix nuget package build on my tip. I also removed skipnuget and skipmscorlib from CI scripts. I think based on discussion with Guarav this should be sufficient to to allow the new Official RID in nuget. |
@jashook Not sure how you want to test CI.... |
Nvm it should be sufficient to just generate the jobs. |
@dotnet-bot test CI please |
Fixes #10458 |
@dotnet-bot test Ubuntu arm64 Cross Debug Build |
Ubuntu build failed while building tests on Windows NT @dotnet-bot test Ubuntu arm64 Cross Debug Build |
@dotnet-bot test Ubuntu arm64 Cross Debug Build |
@jashook does "Ubuntu arm64 Cross Debug Build" error need to be fixed before this can be merged? |
Ignore the failure for now. The failure is unrelated. |
@jashook I was trying to interpret your "sufficient to generate the jobs" comment above. Since the Ubuntu arm64 is broken, I was not sure whether this "sufficiency" was actually met and this PR could be merged w/o breaking release flow. |
@sdmaclea when there is a groovy change we cannot test the jobs that are generated. So whether the job you are changing fails or passes in this PR is unrelated because it is not the job being generated |
@BruceForstall As far as I am concerned, I think this is good to go. But I think it is @jashook & @wtgodbe call aboult whether release CI is ready for this. |
Is this intended to add a linux-arm64 job to the CI? If so, I don't understand how it's doing so. If the intent is just to add support for that RID, then LGTM. |
@wtgodbe No this is not adding linux arm64 job to CI only RID. I thought this was adding linux-arm64 as an official package, and might require something to prevent breaking CI builds which populate the Official and Daily builds. |
I don't believe that should be a problem, if we're adding a package that shouldn't break anything, only subtracting would. |
@BruceForstall Please merge |
@dotnet-bot test Ubuntu arm64 Cross Debug Build |
@BruceForstall Ubuntu arm64 Cross Debug Build build is broken per @jashook There has never been a green run. |
@sdmaclea hmmm... looks like it passed. |
@BruceForstall There was a weird effect where it would pass then fail later. Maybe @jashook fixed, or you merged while it was passing. |
@sdmaclea @BruceForstall ubuntu arm64 jobs are still needed to be worked on. |
No description provided.