Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[Arm64/Unix] Add OfficialBuildRID linux-arm64 #12372

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

sdmaclea
Copy link

No description provided.

@sdmaclea
Copy link
Author

@dotnet/arm64-contrib Not sure if this is too soon, but like to hear what is required before this can be merged.

One of many steps to resolve #10458 and get cli support on linux-arm64

@sdmaclea sdmaclea changed the title [Arm64/Unix] Add OfficialBuildRID linux-arm64 [WIP][Arm64/Unix] Add OfficialBuildRID linux-arm64 Jun 20, 2017
@sdmaclea
Copy link
Author

@gkhanna79 @jashook I made the changes to fix nuget package build on my tip. I also removed skipnuget and skipmscorlib from CI scripts. I think based on discussion with Guarav this should be sufficient to to allow the new Official RID in nuget.

@sdmaclea
Copy link
Author

@jashook Not sure how you want to test CI....

@sdmaclea sdmaclea changed the title [WIP][Arm64/Unix] Add OfficialBuildRID linux-arm64 [Arm64/Unix] Add OfficialBuildRID linux-arm64 Jun 22, 2017
@jashook
Copy link

jashook commented Jun 22, 2017

Nvm it should be sufficient to just generate the jobs.

@jashook
Copy link

jashook commented Jun 22, 2017

@dotnet-bot test CI please

@sdmaclea
Copy link
Author

Fixes #10458

@sdmaclea
Copy link
Author

@dotnet-bot test Ubuntu arm64 Cross Debug Build

@sdmaclea
Copy link
Author

Ubuntu build failed while building tests on Windows NT error C3859: virtual memory range for PCH exceeded; please recompile with a command line option of '-Zm69' or greater

@dotnet-bot test Ubuntu arm64 Cross Debug Build

@sdmaclea
Copy link
Author

sdmaclea commented Jul 5, 2017

@dotnet-bot test Ubuntu arm64 Cross Debug Build

@sdmaclea
Copy link
Author

@jashook does "Ubuntu arm64 Cross Debug Build" error need to be fixed before this can be merged?

@jashook
Copy link

jashook commented Jul 25, 2017

Ignore the failure for now. The failure is unrelated.

@sdmaclea
Copy link
Author

@jashook I was trying to interpret your "sufficient to generate the jobs" comment above. Since the Ubuntu arm64 is broken, I was not sure whether this "sufficiency" was actually met and this PR could be merged w/o breaking release flow.

@jashook
Copy link

jashook commented Jul 25, 2017

@sdmaclea when there is a groovy change we cannot test the jobs that are generated. So whether the job you are changing fails or passes in this PR is unrelated because it is not the job being generated

@BruceForstall
Copy link
Member

@jashook @wtgodbe @sdmaclea Does this change still need work/testing before being merged?

@sdmaclea
Copy link
Author

sdmaclea commented Aug 1, 2017

@BruceForstall As far as I am concerned, I think this is good to go. But I think it is @jashook & @wtgodbe call aboult whether release CI is ready for this.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 1, 2017

Is this intended to add a linux-arm64 job to the CI? If so, I don't understand how it's doing so. If the intent is just to add support for that RID, then LGTM.

@sdmaclea
Copy link
Author

sdmaclea commented Aug 1, 2017

@wtgodbe No this is not adding linux arm64 job to CI only RID.

I thought this was adding linux-arm64 as an official package, and might require something to prevent breaking CI builds which populate the Official and Daily builds.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 1, 2017

I don't believe that should be a problem, if we're adding a package that shouldn't break anything, only subtracting would.

@sdmaclea
Copy link
Author

sdmaclea commented Aug 1, 2017

@BruceForstall Please merge

@BruceForstall
Copy link
Member

@dotnet-bot test Ubuntu arm64 Cross Debug Build

@sdmaclea
Copy link
Author

sdmaclea commented Aug 1, 2017

@BruceForstall Ubuntu arm64 Cross Debug Build build is broken per @jashook There has never been a green run.

@BruceForstall
Copy link
Member

@sdmaclea hmmm... looks like it passed.

@BruceForstall BruceForstall merged commit ca006da into dotnet:master Aug 2, 2017
@sdmaclea
Copy link
Author

sdmaclea commented Aug 2, 2017

@BruceForstall There was a weird effect where it would pass then fail later. Maybe @jashook fixed, or you merged while it was passing.

@sdmaclea sdmaclea deleted the PR-OfficialBuildRID branch August 2, 2017 00:27
@jashook
Copy link

jashook commented Aug 2, 2017

@sdmaclea @BruceForstall ubuntu arm64 jobs are still needed to be worked on.

@karelz karelz modified the milestone: 2.1.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants