-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[Arm64/Unix] Add OfficialBuildRID linux-arm64 #21236
Conversation
@dotnet/arm64-contrib Not sure if this is too soon, but like to hear what is required before this can be merged. One of many steps to resolve https://github.com/dotnet/coreclr/issues/10458 and get cli support on linux-arm64 |
I can take a look, or @weshaggard or @ericstj would be capable as well. |
This change looks fine - but have we added support to build the corresponding packages as part of the arm64 build @sdmaclea ? |
Likewise for CoreCLR as well? |
@gkhanna79 I do not know. Is there something I should look for? artifacts in the CI runs? Code in *.groovy scripts? |
@sdmaclea When CoreCLR is built, we produce nuget packages for it using infra at https://github.com/dotnet/coreclr/blob/master/src/.nuget/packages.builds. You should ensure that it is happening for CoreCLR linux-arm64 builds. |
@jashook Looks like based on comments here https://github.com/dotnet/coreclr/blob/master/netci.groovy#L1707 arm64 linux does not have corefx ci running. So I expect this PR is blocked by that? |
Added issue #21384 assuming linux-arm64 native builds are not occurring in CI. |
@sdmaclea what is status of this PR? Do you plan to move it forward? Is it blocked on anything? |
@karelz I think the patch is functionally complete and correct. However, I think it will break your release flow as corefx Arm64 binaries are not being built in CI (#21384). I could take a shot at drafting the change to netci.groovy, but I would unable to test and also might be blocked by missing packages on your Ubuntu 16.04 machines (where I'd like to build arm64). I think @jashook or another .NET CI expert would likely have more success. |
@wtgodbe Does the same apply here? CI builds of arm64 native are not required before adding the RID? |
I'm less certain about CoreFX, @weshaggard or @jashook may know more here. |
@weshaggard @jashook @wtgodbe I regularly cross build the native components on Ubuntu 16.04 with
Once the Ubuntu and the ROOTFS had all the necessary packages, it has not failed since 1/2017. |
@weshaggard I can look into adding linux arm64 builds for CoreCLR if desired |
@weshaggard @karelz Based on @weshaggard 's comment above, I believe this can be merged w/o breaking anything. |
@wtgodbe can you please be sure there are issues for linux-arm64 for all our repo's (coreclr/corefx/core-setup)? |
[Arm64/Unix] Add OfficialBuildRID linux-arm64 Commit migrated from dotnet/corefx@48d7918
No description provided.