Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[Arm64/Unix] Add OfficialBuildRID linux-arm64 #21236

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

sdmaclea
Copy link
Contributor

No description provided.

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 19, 2017

@dotnet/arm64-contrib Not sure if this is too soon, but like to hear what is required before this can be merged.

One of many steps to resolve https://github.com/dotnet/coreclr/issues/10458 and get cli support on linux-arm64

@karelz
Copy link
Member

karelz commented Jun 20, 2017

@eerhardt are you the right person to code review such change? Or is it @janvorli?

@eerhardt
Copy link
Member

I can take a look, or @weshaggard or @ericstj would be capable as well.

@gkhanna79
Copy link
Member

This change looks fine - but have we added support to build the corresponding packages as part of the arm64 build @sdmaclea ?

@gkhanna79
Copy link
Member

Likewise for CoreCLR as well?

@sdmaclea
Copy link
Contributor Author

@gkhanna79 I do not know. Is there something I should look for? artifacts in the CI runs? Code in *.groovy scripts?

@gkhanna79
Copy link
Member

@sdmaclea When CoreCLR is built, we produce nuget packages for it using infra at https://github.com/dotnet/coreclr/blob/master/src/.nuget/packages.builds. You should ensure that it is happening for CoreCLR linux-arm64 builds.

@sdmaclea sdmaclea changed the title [Arm64/Unix] Add OfficialBuildRID linux-arm64 [WIP][Arm64/Unix] Add OfficialBuildRID linux-arm64 Jun 20, 2017
@karelz karelz modified the milestone: 2.1.0 Jun 20, 2017
@sdmaclea
Copy link
Contributor Author

@jashook Looks like based on comments here https://github.com/dotnet/coreclr/blob/master/netci.groovy#L1707 arm64 linux does not have corefx ci running. So I expect this PR is blocked by that?

@sdmaclea
Copy link
Contributor Author

Added issue #21384 assuming linux-arm64 native builds are not occurring in CI.

@karelz
Copy link
Member

karelz commented Jul 17, 2017

@sdmaclea what is status of this PR? Do you plan to move it forward? Is it blocked on anything?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jul 17, 2017

@karelz I think the patch is functionally complete and correct. However, I think it will break your release flow as corefx Arm64 binaries are not being built in CI (#21384). I could take a shot at drafting the change to netci.groovy, but I would unable to test and also might be blocked by missing packages on your Ubuntu 16.04 machines (where I'd like to build arm64). I think @jashook or another .NET CI expert would likely have more success.

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Aug 2, 2017

@wtgodbe Does the same apply here? CI builds of arm64 native are not required before adding the RID?

@wtgodbe
Copy link
Member

wtgodbe commented Aug 2, 2017

I'm less certain about CoreFX, @weshaggard or @jashook may know more here.

@weshaggard
Copy link
Member

@wtgodbe Does the same apply here? CI builds of arm64 native are not required before adding the RID?

I don't think CI is a requirement but we do need to ensure that we can actually build and are setup to produce an official build for arm64. @wtgodbe @jashook are one of you guys working on that?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Aug 3, 2017

@weshaggard @jashook @wtgodbe I regularly cross build the native components on Ubuntu 16.04 with

ROOTFS_DIR=<path>/arm64-xenial-rootfs
./build-native.sh -${buildType} -buildArch=arm64 -portableBuild

Once the Ubuntu and the ROOTFS had all the necessary packages, it has not failed since 1/2017.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 3, 2017

@weshaggard I can look into adding linux arm64 builds for CoreCLR if desired

@sdmaclea sdmaclea changed the title [WIP][Arm64/Unix] Add OfficialBuildRID linux-arm64 [Arm64/Unix] Add OfficialBuildRID linux-arm64 Aug 3, 2017
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Aug 3, 2017

@weshaggard @karelz Based on @weshaggard 's comment above, I believe this can be merged w/o breaking anything.

@weshaggard
Copy link
Member

@wtgodbe can you please be sure there are issues for linux-arm64 for all our repo's (coreclr/corefx/core-setup)?

@weshaggard weshaggard merged commit 48d7918 into dotnet:master Aug 3, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
[Arm64/Unix] Add OfficialBuildRID linux-arm64

Commit migrated from dotnet/corefx@48d7918
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants