This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port of https://github.com/dotnet/coreclr/pull/12795 to release/1.0.0 #12941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravimeda
reviewed
Jul 20, 2017
init-tools.sh
Outdated
| echo "Initializing BuildTools..." | ||
| echo "Running: $__BUILD_TOOLS_PATH/init-tools.sh $__scriptpath $__DOTNET_CMD $__TOOLRUNTIME_DIR" >> $__init_tools_log | ||
| # On ubuntu 14.04, /bin/sh (symbolic link) calls /bin/dash by default. | ||
| $__BUILD_TOOLS_PATH/init-tools.sh $__scriptpath $__DOTNET_CMD $__TOOLRUNTIME_DIR |
There was a problem hiding this comment.
Similar to my earlier comment, consider redirecting output to the log. Refer to https://github.com/dotnet/corefx/blob/master/init-tools.sh#L113
ravimeda
reviewed
Jul 20, 2017
init-tools.sh
Outdated
|
|
||
| if [ ! -e $__BUILD_TOOLS_PATH ]; then | ||
| echo "Running: $__DOTNET_CMD restore "$__PROJECT_JSON_FILE" --packages $__PACKAGES_DIR --source $__BUILDTOOLS_SOURCE" >> $__init_tools_log | ||
| $__DOTNET_CMD restore "$__PROJECT_JSON_FILE" --packages $__PACKAGES_DIR --source $__BUILDTOOLS_SOURCE |
There was a problem hiding this comment.
$__DOTNET_CMD restore "$__PROJECT_JSON_FILE" --packages $__PACKAGES_DIR --source $__BUILDTOOLS_SOURCE
Consider redirecting this output to the log. Please refer to https://github.com/dotnet/corefx/blob/master/init-tools.sh#L101
karajas
force-pushed
the
fixInitTools/release/1.0.0
branch
from
ae49685 to
6debec6
Compare
dagood
reviewed
Jul 21, 2017
| :: If semaphore exists do nothing | ||
| if exist "%BUILD_TOOLS_SEMAPHORE%" ( | ||
| echo Tools are already initialized. | ||
| goto :DONE |
There was a problem hiding this comment.
Master has :EOF here, rather than :DONE. This PR removes the DONE label, resulting in failures when tools are already initialized.
karajas
force-pushed
the
fixInitTools/release/1.0.0
branch
from
6debec6 to
ec0edfb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ravimeda