Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Sep 28, 2017

... until it can work. FYI @wtgodbe

@mmitche
Copy link
Member

mmitche commented Sep 29, 2017

@dotnet-bot test this please

@mmitche
Copy link
Member

mmitche commented Sep 29, 2017

@dotnet-bot test Windows_NT x64 CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x86 CoreCLR Perf Tests Correctness

@MattGal
Copy link
Member Author

MattGal commented Sep 29, 2017

I appreciate the help @mmitche but this was a pipebuild change (i.e. CI tests didn't matter, I thought we didn't want to waste machine's time running them...)

@MattGal MattGal merged commit fb7c827 into release/2.0.0 Sep 29, 2017
@mmitche
Copy link
Member

mmitche commented Sep 29, 2017

@MattGal Was just testing some stuff.

@jkotas jkotas deleted the Disable_PDB_Conversion branch October 4, 2017 05:15
@weshaggard
Copy link
Member

@MattGal @dagood after disabling this step the "Publish Symbols to Artifact Services" step also fails because it is expecting files from that step. So I disabled all steps in this build definition with commit ce8e4e7 until we figure out the plan. @dagood I assume there is an issue somewhere tracking re-enabling these steps.

@dagood
Copy link
Member

dagood commented Nov 17, 2017

https://github.com/dotnet/core-eng/issues/1771 tracks the specific error we see in CoreCLR.

https://github.com/dotnet/core-eng/issues/2073 tracks making the conversion generally more resilient and making it so you can add exceptions rather than blanket enable/disable.

@MattGal
Copy link
Member Author

MattGal commented Nov 20, 2017

Thanks @dagood. @weshaggard, my understanding was that all types of publish would be controlled by commonly-named flags which we could then use Conditional Task behaviors to turn off and on as has been done in master. So, once we pick which flag should do that, the change to add conditions to disable all (appropriate) steps at once should be as simple as adding those conditions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants