Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

release/2.0: Workaround GetSystemTimePreciseAsFileTime inaccuracies #14319

Merged
merged 1 commit into from
Oct 4, 2017
Merged

release/2.0: Workaround GetSystemTimePreciseAsFileTime inaccuracies #14319

merged 1 commit into from
Oct 4, 2017

Conversation

stephentoub
Copy link
Member

Port #14283 to release/2.0.0 branch

@stephentoub
Workaround GetSystemTimePreciseAsFileTime inaccuracies (dotnet#14283)
4fed9f8 
* Workaround GetSystemTimePreciseAsFileTime inaccuracies

On misconfigured systems, GetSystemTimePreciseAsFileTime may drift quickly from GetSystemTimeAsFileTime.  We want to use the former, though.  As a workaround/heuristic, when checking whether we have GetSystemTimePreciseAsFileTime, invoke both and ensure they're "close", falling back to GetSystemTimeAsFileTime if it seems like the precise variant has run away.

* Update comment
@stephentoub stephentoub added this to the 2.0.x milestone Oct 4, 2017
@stephentoub
Copy link
Member Author

stephentoub commented Oct 4, 2017 •
edited
Loading

The Windows_NT arm builds are failing with:

D:/j/workspace/arm_cross_deb---8bd6fb7e/src/debug/ee/arm/dbghelpers.asm(5): fatal error C1083: Cannot open include file: 'ksarm.h': No such file or directory [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\debug\ee\wks\cordbee_wks.vcxproj]
D:/j/workspace/arm_cross_deb---8bd6fb7e/src/vm/arm/asmhelpers.asm(10): fatal error C1083: Cannot open include file: 'ksarm.h': No such file or directory [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\vm\wks\cee_wks.vcxproj]
LINK : fatal error LNK1104: cannot open file 'WtsApi32.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\dlls\dbgshim\dbgshim.vcxproj]
LINK : fatal error LNK1104: cannot open file 'dbghelp.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\ToolBox\SOS\Strike\sos.vcxproj]
LINK : fatal error LNK1104: cannot open file 'version.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\ToolBox\superpmi\superpmi\superpmi.vcxproj]
LINK : fatal error LNK1104: cannot open file 'version.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\dlls\mscordbi\mscordbi.vcxproj]
LINK : fatal error LNK1104: cannot open file 'version.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\jit\standalone\clrjit.vcxproj]
LINK : fatal error LNK1104: cannot open file 'version.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\jit\protojit\protojit.vcxproj]
LINK : fatal error LNK1104: cannot open file 'version.lib' [D:\j\workspace\arm_cross_deb---8bd6fb7e\bin\obj\Windows_NT.arm.Debug\src\tools\crossgen\crossgen.vcxproj]

That's unrelated to this PR.
https://github.com/dotnet/coreclr/issues/12902

@stephentoub stephentoub merged commit 2a5b736 into dotnet:release/2.0.0 Oct 4, 2017
@stephentoub stephentoub deleted the port14283 branch October 4, 2017 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @dnfclas