This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port to 1.0.0 - Fix passing struct with four floats in registers via reflection #14392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reflection This change fixes a bug in the code that copies a struct into the transition frame. When it contains four floats, the first two are put to the right place, but the following two are placed to an address that's offset by 8 instead of by 16. It also adds regression test for this problem as Pri 1 test.
|
Fixes #14391 |
|
@dotnet-bot test CentOS7.1 x64 Release Priority 1 Build and Test please |
|
@dotnet-bot test Ubuntu x64 Checked Build and Test please |
|
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please |
|
The Pri 1 tests are failing due to the new test. It looks like the project needs to be tweaked for the 1.0.0 somehow: |
|
@mmitche, the build "Ubuntu x64 Checked Build and Test" in 1.0.0 branch has failed due to missing lldb-3.6-dev package. @mikem8361 have you removed it when you were adding the support for llvm3.9? |
|
@mikem8361 I didn't remove it...did you? |
|
Should we go through all the VMs again (at the ones that will do 1.x builds) and re-install lldb-3.6-dev? I'm sorry Matt to put you through all of that again because of my mistake.
From: Mike McLaughlin
Sent: Thursday, October 12, 2017 9:54 AM
To: dotnet/coreclr <reply@reply.github.com>; dotnet/coreclr <coreclr@noreply.github.com>
Cc: Mention <mention@noreply.github.com>
Subject: Re: [dotnet/coreclr] Port to 1.0.0 - Fix passing struct with four floats in registers via reflection (#14392)
Yes I did remove lldb dev 3.6. I didn't think about older builds like this that doesn't look for 3.9. I was making sure we always built with 3.9 in the later.
|
|
We could also roll back to the previous image for 1.0. How many did you remove 3.6 from?
Matt
From: Mike McLaughlin [mailto:notifications@github.com]
Sent: Thursday, October 12, 2017 10:10 AM
To: dotnet/coreclr <coreclr@noreply.github.com>
Cc: Matt Mitchell <mmitche@microsoft.com>; Mention <mention@noreply.github.com>
Subject: Re: [dotnet/coreclr] Port to 1.0.0 - Fix passing struct with four floats in registers via reflection (#14392)
Should we go through all the VMs again (at the ones that will do 1.x builds) and re-install lldb-3.6-dev? I'm sorry Matt to put you through all of that again because of my mistake.
From: Mike McLaughlin
Sent: Thursday, October 12, 2017 9:54 AM
To: dotnet/coreclr <reply@reply.github.com<mailto:reply@reply.github.com>>; dotnet/coreclr <coreclr@noreply.github.com<mailto:coreclr@noreply.github.com>>
Cc: Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>>
Subject: Re: [dotnet/coreclr] Port to 1.0.0 - Fix passing struct with four floats in registers via reflection (#14392)
Yes I did remove lldb dev 3.6. I didn't think about older builds like this that doesn't look for 3.9. I was making sure we always built with 3.9 in the later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcoreclr%2Fpull%2F14392%23issuecomment-336202962&data=02%7C01%7Cmmitche%40microsoft.com%7C0b112d289a264ad696a908d5119411e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636434250004365196&sdata=m%2F1OY%2FyXzdDriKW8RErsAoc05dPN%2BwTbAFdSATvD7ao%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIUism7NPKuxTv6F-o20Non1Bcdvp1vYks5srkfmgaJpZM4PyrxW&data=02%7C01%7Cmmitche%40microsoft.com%7C0b112d289a264ad696a908d5119411e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636434250004375205&sdata=p2bxzwspTdgjtkn5XLV9YZQnJB4OX0MRrWi6OS9KFm0%3D&reserved=0>.
|
|
Pretty much all of them that had it installed.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports a fix for a bug in the code that copies a struct into the transition
frame. When it contains four floats, the first two are put to the right place,
but the following two are placed to an address that's offset by 8 instead of
by 16.
It also ports regression test for this problem as Pri 1 test.