This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Deprecate copy task #15052
Merged
Deprecate copy task #15052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I swear I put comments here :( but either way, trying it again. |
maririos
reviewed
Nov 17, 2017
| "definitionType": "task" | ||
| }, | ||
| "inputs": { | ||
| "SourceFolder": "$(PB_GitDirectory)", |
There was a problem hiding this comment.
Is it save to overwrite the source folder that the task was using before? Will we get the same content?
There was a problem hiding this comment.
sorry copy paste error, fixing now.
maririos
reviewed
Nov 17, 2017
| "inputs": { | ||
| "CopyRoot": "$(DockerCopyDest)", | ||
| "PathtoPublish": "$(Build.StagingDirectory)\\BuildLogs", | ||
| "Contents": "**/*.log", |
There was a problem hiding this comment.
I haven't seen a field called Contents in the Publish task. Did u test it?
maririos
reviewed
Nov 17, 2017
| }, | ||
| "inputs": { | ||
| "SourceFolder": "$(PB_GitDirectory)", | ||
| "Contents": "**/*.log", |
There was a problem hiding this comment.
You are overwriting the Contents property. I guess the question for the source applies here too
karajas
force-pushed
the
copytaskrel2.0
branch
from
d6d19d9 to
3ca5e23
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chcosta @maririos