Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

shrah
Copy link

@shrah shrah commented Jan 4, 2018

This fixes https://github.com/dotnet/corefx/issues/25960 in 2.0.0 by porting the #13553 change from master.

@tarekgh @tijoytom @karelz @danmosemsft

@tarekgh
Copy link
Member

tarekgh commented Jan 4, 2018

LGTM. Is it possible you validate the fix to ensure it is really fixed the issue? Thanks.

@shrah
Copy link
Author

shrah commented Jan 4, 2018

@dotnet-bot test Ubuntu arm Cross Release Build
@dotnet-bot test Ubuntu16.04 arm Cross Debug Build
@dotnet-bot test Windows_NT arm Cross Debug Build
@dotnet-bot test Windows_NT arm Cross Release Build

@shrah
Copy link
Author

shrah commented Jan 5, 2018

@dotnet-bot test Ubuntu arm Cross Release Build
@dotnet-bot test Ubuntu16.04 arm Cross Debug Build
@dotnet-bot test Windows_NT arm Cross Debug Build
@dotnet-bot test Windows_NT arm Cross Release Build

@danmoseley
Copy link
Member

The ARM legs are broken. @RussKeldorph did you say you might know why they are enabled/who would own fixing them?

Meantime I think it is OK to ignore these. We do not ship 2.0.x for ARM ourselves and we know this already works in master.

@shrah
Copy link
Author

shrah commented Jan 5, 2018

@tarekgh , I have verified in local machine that it indeed fixes the issue.

@shrah
Copy link
Author

shrah commented Jan 5, 2018

@danmosemsft , should I just go ahead and merge it?

@danmoseley
Copy link
Member

@shrah , @safern or @wtgodbe will ping you when the branch opens - or just hit merge thesmelves.

@safern
Copy link
Member

safern commented Jan 6, 2018

branches are ready to merge now.

@safern safern merged commit b5c6996 into dotnet:release/2.0.0 Jan 6, 2018
@tarekgh
Copy link
Member

tarekgh commented Jan 6, 2018

thanks @shrah for porting the fix.

@karelz karelz added this to the 2.0.x milestone May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants