This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix GC.KeepAlive test case #15835
Merged
Fix GC.KeepAlive test case #15835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the test, as written, a GC could sneak in between the GC.KeepAlive() call and the subsequent line that checks whether the finalizer has run, especially in GC stress modes. Simply move the GC.KeepAlive() call down.
|
Fixes ARM GCStress failures. |
|
@dotnet-bot test Windows_NT arm Cross Checked gcstress0xc Build and Test |
|
cc @dotnet/jit-contrib |
swgillespie
approved these changes
Jan 12, 2018
|
|
||
| GC.Collect(); | ||
| GC.WaitForPendingFinalizers(); | ||
| GC.Collect(); |
There was a problem hiding this comment.
This pattern is known to be flaky. I addressed a few tests that rely on this pattern here: #11216. If this test isn't flaky, I don't think there's any reason to address it here, but as it's written it's possible for the test to fail if we take a really unlucky path through the scheduler.
There was a problem hiding this comment.
Interesting. No, flakiness isn't the issue I was seeing; it's that the lifetime of tc was simply incorrect.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test, as written, a GC could sneak in between the GC.KeepAlive()
call and the subsequent line that checks whether the finalizer
has run, especially in GC stress modes. Simply move the GC.KeepAlive()
call down.