This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix detection of YMM registers presence #16168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
|
LGTM |
adityamandaleeka
approved these changes
Feb 2, 2018
janvorli
added a commit
to janvorli/coreclr
that referenced
this pull request
Feb 26, 2018
Port dotnet#16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
janvorli
added a commit
to janvorli/coreclr
that referenced
this pull request
Feb 26, 2018
Port dotnet#16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
janvorli
added a commit
to janvorli/coreclr
that referenced
this pull request
Feb 26, 2018
Port dotnet#16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
This was referenced Feb 26, 2018
janvorli
added a commit
to janvorli/coreclr
that referenced
this pull request
Feb 26, 2018
Port dotnet#16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
janvorli
added a commit
that referenced
this pull request
Mar 8, 2018
Port #16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
janvorli
added a commit
that referenced
this pull request
Mar 8, 2018
Port #16168 It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
It was found that we incorrectly try to restore YMM registers in RtlRestoreContext when the processor supports xstate, but doesn't have YMM registers. This change fixes that by testing the YMM presence flag too. Commit migrated from dotnet/coreclr@158f16d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that we incorrectly try to restore YMM registers in RtlRestoreContext
when the processor supports xstate, but doesn't have YMM registers. This change
fixes that by testing the YMM presence flag too.
Closes #16052