Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

kouvel
Copy link

@kouvel kouvel commented Oct 2, 2015

Not removing the 'includetests' parameter for now, as dependencies on it have been taken.

@kouvel
Copy link
Author

kouvel commented Oct 2, 2015

@sergiy-k @mmitche

@mmitche
Copy link
Member

mmitche commented Oct 2, 2015

@dotnet-bot test this please (FreeBSD machine was horked)

build.sh Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this no longer does anything, we should remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, will do

@mmitche
Copy link
Member

mmitche commented Oct 2, 2015

LGTM

mmitche added a commit that referenced this pull request Oct 2, 2015
On builds outside Windows, build native test components by default
@mmitche mmitche merged commit 125fd81 into dotnet:master Oct 2, 2015
@kouvel kouvel deleted the IncludeTestsInBuildSh branch October 3, 2015 00:30
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
On builds outside Windows, build native test components by default

Commit migrated from dotnet/coreclr@125fd81
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants