Apply StackString for pal MAX_LONGPATH references.

[Priya91]

cc @jkotas @JeremyKuhne @janvorli

[janvorli]

Please fix text alignment here

[janvorli]

LGTM modulo my comments.

[ghost]

nit: extra whitespace.

[Priya91]

"d:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\install.vcxproj" (default target) (1) ->
15:52:17        "D:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\ALL_BUILD.vcxproj" (default target) (2) ->
15:52:17        "D:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\src\dlls\mscoree\coreclr\coreclr.vcxproj" (default target) (20) ->
15:52:17        "D:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\src\dlls\mscordac\mscordaccore.vcxproj" (default target) (34) ->
15:52:17        "D:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\src\debug\daccess\daccess.vcxproj" (default target) (37) ->
15:52:17          C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\CodeAnalysis\Microsoft.CodeAnalysis.targets(214,5): error MSB4175: The task factory "CodeTaskFactory" could not be loaded from the assembly "C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Build.Tasks.Core.dll". Could not find file 'C:\Users\dotnet-bot\AppData\Local\Temp\pxndwcfe.dll'. [D:\j\workspace\dotnet_coreclr_windows_release_prtest\bin\obj\Windows_NT.x64.Release\src\debug\daccess\daccess.vcxproj]

@dotnet-bot test this please

[janvorli]

LGTM

[Priya91]

build failing with centos job not found

ERROR: Failed to run DSL Script
java.util.concurrent.ExecutionException: com.cloudbees.plugins.flow.JobNotFoundException: Item dotnet_coreclr_linux_centos71_release_prtest not found (or isn't a job).
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:188)
    at java_util_concurrent_Future$get.call(Unknown Source)
    at com.cloudbees.plugins.flow.FlowDelegate$_parallel_closure6.doCall(FlowDSL.groovy:440)
    at sun.reflect.GeneratedMethodAccessor478.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)
    at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)
    at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:272)
    at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:903)

@mmitche

[janvorli]

@Priya91 That's a good point. It seems it could be null if there was an assert or if someone added an explicit call to DebugBreak before the variable is initialized. So we should handle the case.

[Priya91]

@janvorli @jkotas Can you please review the latest commit. Thanks!

[janvorli]

You can just assign integer zero and get rid of this test. That works for both char and WCHAR.

[janvorli]

LGTM modulo the comment

[Priya91]

@mmitche @ellismg : I am blocked by the CodeTaskFactory issue on this PR, the Windows Release builds keep failing with the same error. Should we ignore that failure if that's the only blocking issue with merge?

[mmitche]

Yeah you can probably ignore it.

[mmitche]

/cc @AndyGerlicher @rainersigwald This is the code task factory failure I was talking about