This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[1.1] Add packaging for Fedora27, OpenSuse423, Ubuntu1804 #16973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janvorli @rakeshsinghranchi @weshaggard any comments on this one? |
janvorli
suggested changes
Mar 26, 2018
| <OSGroup>Linux</OSGroup> | ||
| <Platform>amd64</Platform> | ||
| </Project> | ||
| <Project Condition="'$(TargetsLinux)' == 'true' and '$(DistroRid)' == 'ubuntu.18.04-x64'" Include="ubuntu/16.04/Microsoft.NETCore.Runtime.CoreCLR.pkgproj"> |
There was a problem hiding this comment.
The include looks incorrect - it refers to 16.04 instead 18.04.
| <OSGroup>Linux</OSGroup> | ||
| <Platform>amd64</Platform> | ||
| </Project> | ||
| <Project Condition="'$(TargetsLinux)' == 'true' and '$(DistroRid)' == 'opensuse.42.3-x64'" Include="opensuse/42.1/Microsoft.NETCore.Runtime.CoreCLR.pkgproj"> |
There was a problem hiding this comment.
The include looks incorrect - it refers to 42.1 instead 42.3.
| <OSGroup>Linux</OSGroup> | ||
| <Platform>amd64</Platform> | ||
| </Project> | ||
| <Project Condition="'$(TargetsLinux)' == 'true' and '$(DistroRid)' == 'fedora.27-x64'" Include="fedora/24/Microsoft.NETCore.Runtime.CoreCLR.pkgproj"> |
There was a problem hiding this comment.
The include looks incorrect - it refers to 24 instead 27.
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> | ||
| <PropertyGroup> | ||
| <SkipPackageFileCheck>true</SkipPackageFileCheck> | ||
| <PackageTargetRuntime>opensuse.42.2-$(PackagePlatform)</PackageTargetRuntime> |
There was a problem hiding this comment.
This refers to 42.2, but the file is for 42.3.
| <OSGroup>Linux</OSGroup> | ||
| <Platform>amd64</Platform> | ||
| </Project> | ||
| <Project Condition="'$(TargetsLinux)' == 'true' and '$(DistroRid)' == 'fedora.27-x64'" Include="fedora/24/Microsoft.NETCore.TestHost.pkgproj"> |
There was a problem hiding this comment.
In this file, the includes also seem to have distro version mismatch at multiple places.
|
@janvorli thanks for noticing the copy-paste errors, I fixed them. |
janvorli
approved these changes
Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @ericstj @weshaggard @janvorli @dagood