Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Oct 7, 2015

No description provided.

@mmitche
Copy link
Member Author

mmitche commented Oct 7, 2015

The old pr test and commit jobs have now been disabled (though not deleted yet)

@ghost
Copy link

ghost commented Oct 7, 2015

@mmitche, can we also get hook to codecov-io summary in PRs with this cool new groovy-driven infrastructure? :)

It will look something like:

(it will be just one comment per PR regardless of number of rebases / adding or removing commits; as they mentioned here: dotnet/corefx#3368)

@mmitche
Copy link
Member Author

mmitche commented Oct 7, 2015

We don't today run code coverage on every PR, but I'll probably add it as an on-demand thing. I can look to add the hook then.

@mmitche
Copy link
Member Author

mmitche commented Oct 8, 2015

Anyone have objections to me merging this?

mmitche added a commit that referenced this pull request Oct 8, 2015
Update badges to new job locations
@mmitche mmitche merged commit 1dafc0b into dotnet:master Oct 8, 2015
@mmitche mmitche deleted the update-badges branch October 8, 2015 22:25
@ghost
Copy link

ghost commented Oct 9, 2015

@mmitche,
That sounds good. Probably @sharwell and co. can help us configuring code coverage and codecov hook, as they already have done it for several repos under https://github.com/DotNetAnalyzers.

Sorry I forgot to comment on the organization of badges earlier, but wouldn't it be nice to have it transposed such that Debug/Release become columns and platforms rows; essentially to get rid of the scroll bars with the ever growing matrix?
Also, in future the platform names may grow in length; "FreeBSD 10.2 x86 Release" or "Linux on ARM v7 (64-bit) Debug" etc.

@sharwell
Copy link

sharwell commented Oct 9, 2015

@jasonwilliams200OK codecov.io automatically detects when the build is running on AppVeyor and links the information to the parent repository, so there's no need to set up any hooks or authentication keys or anything. Our configuration to enable code coverage reporting is contained within the test_script section of our appveyor.yml, plus one line in our solution-level packages.config file. After setting everything up I contributed some (hopefully) helpful information back in codecov/example-csharp#3.

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Update badges to new job locations

Commit migrated from dotnet/coreclr@1dafc0b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants