Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

sdmaclea
Copy link

Fixes #17166
@janvorli I haven't tried running it yet.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sdmaclea
Copy link
Author

Looks like the assembly code needs to be debugged. It core dumped.

@sdmaclea
Copy link
Author

This is a necessary step, but it is not sufficient.

I would merge this.

@janvorli janvorli merged commit 8e05975 into dotnet:master Mar 26, 2018
@sdmaclea sdmaclea deleted the stubs branch April 16, 2018 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants