This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix OSX hardware exception and activation collision #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a collision between hardware exception handling and activation injection. Both require creating helper frame on stack and patching the target thread context to inject invocation of a handler. When these two happened together, they both tried to update the context and create helper frame on stack at the same time, which lead to various issues including PAL_SEHException escaping from the host application unhandled.
janvorli
force-pushed
the
fix-osx-activation-and-exception-collision
branch
from
c3c4c4f to
278285a
Compare
|
LGTM |
janvorli
added a commit
that referenced
this pull request
Oct 8, 2015
…on-collision Fix OSX hardware exception and activation collision
|
this 278285a has been pulled into the beta8 release branch. 4.0.1-beta-23409 packages at https://www.myget.org/F/aspnetbeta8/api/v2/package contain the fix |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…on-and-exception-collision Fix OSX hardware exception and activation collision Commit migrated from dotnet/coreclr@a0b2e33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a collision between hardware exception handling and activation
injection. Both require creating helper frame on stack and patching the target thread
context to inject invocation of a handler. When these two happened together,
they both tried to update the context and create helper frame on stack at the same
time, which lead to various issues including PAL_SEHException escaping from
the host application unhandled.