This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Don't require all-user permissions on the temp directory for named mutexes on Unix under docker #17206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…texes on Unix under docker Avoids the need for a workaround for one of the issues seen in https://github.com/dotnet/coreclr/issues/17098
|
Are there associated tests? Maybe in corefx? |
stephentoub
approved these changes
Mar 25, 2018
|
To test this it would either require a test hook in the PAL or it would be necessary to reduce permissions on /tmp for at least other users, probably not safe to do as part of unit tests. It should be ok to do in a docker container, if there's a CI job that runs tests in a docker container, and if the test can know that it's running inside docker it could enable the test. |
|
Ok. Thanks. |
janvorli
approved these changes
Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the need for a workaround for one of the issues seen in https://github.com/dotnet/coreclr/issues/17098