This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix GC tests. #17594
Merged
Merged
Fix GC tests. #17594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd662af
to
69a18b1
Compare
@dotnet-bot test Windows_NT arm Cross Checked r2r_jitstressregs3 Build and Test |
cc @Maoni0 |
thanks! |
BruceForstall
approved these changes
Apr 17, 2018
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Apr 17, 2018
* Fix dlbigleak * cleanup dlstack * Fix doublinknoleak * Fix doublinkstay * Fix dlcollect * Fix doublinkgen * Fix dlbigleakthd
sandreenko
pushed a commit
that referenced
this pull request
Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jit can extend lifetime of temp objects after call to GC.Collect(), so we should not have any temp in the same scope with final
GC.Collect();
.incorrect example 1:
incorrect example 2:
Incorrect example 3:
correct example 1:
Fixes #17588.
The same problem as #15156.