This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port two changes from CoreFX to *memory.cs that were missed by mirror #17713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b4d701a Author: Ahson Khan <ahkha@microsoft.com> Date: Wed Apr 11 13:43:36 2018 -0700 Add CreateFromPinnedArray to System.Memory ref and add tests (#28992) * Fixing bug in Memory.Pin and adding API to uapaot baseline commit 76e0104 Author: Ahson Khan <ahkha@microsoft.com> Date: Mon Apr 16 01:54:54 2018 -0700 Update xml comment for {ReadOnly}Memory.Pin method (#29137)
ahsonkhan
approved these changes
Apr 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/corefx@b4d701a
Author: Ahson Khan ahkha@microsoft.com
Date: Wed Apr 11 13:43:36 2018 -0700
Add CreateFromPinnedArray to System.Memory ref and add tests (#28992)
Fixing bug in Memory.Pin and adding API to uapaot baseline
Comments only, porting so we can start the mirror up without issues:
dotnet/corefx@76e0104
Author: Ahson Khan ahkha@microsoft.com
Date: Mon Apr 16 01:54:54 2018 -0700
Update xml comment for {ReadOnly}Memory.Pin method (#29137)
Reconciliation on other side is dotnet/corefx#29256