This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make intra-build feed containers private. #17792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riarenas I think we actually need to put the buildtools change in the release/2.1 branch, so that we don't have to upgrade to buildtools 2.2. |
|
Sure. I'll do that and then update |
|
@mmitche This should be good to check again. All the tooling prereqs needed are now in place. |
mmitche
reviewed
May 2, 2018
|
Shouldn't need one, both the buildtools and Microsoft.DotNet.Build.Tasks.Feed in the branch already got updated to versions that contain the new property. |
mmitche
approved these changes
May 2, 2018
riarenas
added a commit
to riarenas/coreclr
that referenced
this pull request
May 3, 2018
This reverts commit 4950b03.
riarenas
added a commit
that referenced
this pull request
May 3, 2018
…mediate-containers Revert "Make blobfeed containers private. (#17792)"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.