This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove ETW usages of AnsiString and replace them with UnicodeString #17989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancem
approved these changes
May 14, 2018
There was a problem hiding this comment.
Looks good, we will want to update PerfView/TraceEvent, otherwise nothing knows how to decode these events.
Also we should be updating the Desktop version of this file from time to time so that the new events get 'registered' and work with WPA and other tools.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usages of AnsiString in the ETW manifest. This is a requirement to support generating a managed EventSource for these events, which only supports UnicodeString.